Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(send): _NoDefault serializer sentinel introduced in order to make… #280

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

marcosschroh
Copy link
Collaborator

… possible to send raw data even when a global serializer has been set

This PR address the case when the end user wants to send raw data when a global serializer has been set.

Use cases:

  • Multiple topics that expect serialized data, except one: In this case it makes sense to configure a global serializer (StreamEngine) and then produce raw when is needed send(serialzer=None)
  • DLQ: to produce raw data (bytes) after a deserialization has failed

Copy link
Contributor

github-actions bot commented Jan 31, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://kpn.github.io/kstreams/pr-preview/pr-280/

Built to branch gh-pages at 2025-02-03 10:51 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.21%. Comparing base (e308740) to head (ca3f707).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #280      +/-   ##
==========================================
+ Coverage   96.05%   96.21%   +0.15%     
==========================================
  Files          24       24              
  Lines         964      977      +13     
==========================================
+ Hits          926      940      +14     
+ Misses         38       37       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcosschroh marcosschroh force-pushed the fix/introduce-serializer-sentinel branch 2 times, most recently from 2502c52 to 02654ba Compare January 31, 2025 15:10
Copy link

@Masqueey Masqueey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some spelling errors, but in general a very nice PR with good documentation.

docs/serialization.md Outdated Show resolved Hide resolved
docs/serialization.md Outdated Show resolved Hide resolved
docs/serialization.md Outdated Show resolved Hide resolved
docs/serialization.md Outdated Show resolved Hide resolved
docs/serialization.md Outdated Show resolved Hide resolved
kstreams/serializers.py Outdated Show resolved Hide resolved
kstreams/serializers.py Show resolved Hide resolved
kstreams/serializers.py Outdated Show resolved Hide resolved
tests/test_serialization.py Outdated Show resolved Hide resolved
tests/test_serialization.py Outdated Show resolved Hide resolved
… possible to send raw data even when a global serializer has been set
@marcosschroh marcosschroh force-pushed the fix/introduce-serializer-sentinel branch from 02654ba to ca3f707 Compare February 3, 2025 10:50
@marcosschroh marcosschroh merged commit cf235c3 into master Feb 3, 2025
9 checks passed
@marcosschroh marcosschroh deleted the fix/introduce-serializer-sentinel branch February 3, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants