Add ReduceMean node #56
Conversation
|
Before looking in detail into this, I noticed there are a few other |
src/nodes/reducemean.h
Outdated
| * TEMPLATE node. | ||
| * When implementing a new node, use this template | ||
| * as a starting point. | ||
| * | ||
| * This file can be kept as a single .h file with an | ||
| * in-header implementation, or it can be split into | ||
| * a .h and a .cc file. | ||
| * | ||
| * Replace all occurances of TEMPLATE in this file. | ||
| * Some representative dummy implementation provided. | ||
| * | ||
| * The functions here are callbacks from the onnx2c | ||
| * framework. See node.h for more documentation. |
There was a problem hiding this comment.
Comments from the template function left in.
Yes, that seems doable. Perhaps I can implement that change in another PR. |
Nice. And yes, no point in cluttering this PR - it already adds value as is. |
|
I can not compiled the code after added the reduceMean Op. |
|
@tlane-rbx I tried to compile it too only now (sorry for the long dealy). There's quite a few loops over @jellchou was that the same problem you were seeing? |
|
Yes，the same problems发自我的 iPhone在 2024年10月27日，01:23，kraiskil ***@***.***> 写道：
@tlane-rbx I tried to compile it too only now (sorry for the long dealy). There's quite a few loops over std::vector.size() with a signed loop variant. But other than that, this looks good.
@jellchou was that the same problem you were seeing?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Ok, compiles fine now, and looks good. Thanks for the contribution! |
Adds support for ReduceMean ONNX layer and adds a
.gitignorefile.