-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node timing #747
base: main
Are you sure you want to change the base?
Node timing #747
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested different combinations and the reporting is working as expected. Working node scenario configs:
- one action - node_stop_start_scenario targeting one instance count
- one action - node_stop_start_scenario targeting multiple instance count
Scenario with multiple actions is failing to report the metrics due to a bug in the node-scenarios code base outside this PR: #749
@@ -247,6 +253,8 @@ def run_node(self, single_node, node_scenario_object, action, node_scenario): | |||
"There is no node action that matches %s, skipping scenario" | |||
% action | |||
) | |||
logging.info('last line run node') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leftover logging from the test runs, need to remove it.
This is adding in the ability to add AffectedNode timing to a list that we can track in the telemetry and other output.
This tracks the amount of time that is taken for the cloud provider to stop/start the node, and the amount of time after the node from the cloud side is stopped/started what is the time the node is in not ready/ready state.
Needs to go in after krkn-chaos/krkn-lib#143
Any suggestions on how to make this not touch as many files?
New telemetry section will look like this for a stop/start scenario