-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1. Add CRDs for MetadataProfile #1434
1. Add CRDs for MetadataProfile #1434
Conversation
a7b4015
to
654befc
Compare
Which file is currently being used for ROS and the general use case? |
manifests/autotune/metadata-profiles/cluster_metadata_local_monitoring.json
Show resolved
Hide resolved
Can you please include MD file with this PR |
|
Added |
Hi @msvinaykumar, I have incorporated review changes suggested. Can you please review the PR again? |
@@ -0,0 +1,81 @@ | |||
# Metadata Profile | |||
|
|||
The metadata profile contains a list of queries used to retrieve datasource metadata such as list of namespaces, workloads |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, describe the user flow for modifying queries and utilizing API requests and responses, or provide a reference link if this information is documented elsewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing this out. MetadataProfile.md
readme aims to explain what the profile is about and different fields and metadata queries supported. I'll be adding a new readme MetadataProfileAPI.md
as and when the REST APIs are merged which will cover user flow for modifying queries and API requests and responses.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@dinogun As per the feedback updated the measurement duration unit to minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR includes:
Fixes # (issue)
Type of change
How has this been tested?
Please describe the tests that were run to verify your changes and steps to reproduce. Please specify any test configuration required.
Test Configuration
Checklist 🎯
Additional information
.