-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added gRPC endpoint and python client #21
Conversation
I am on PTO now until 19th April, so will respond to comments when I return |
@johnaohara Hi John, sorry just back from PTO, I see that there is a conflict, can you please resolve that. Also we are adding a demo / example script here, would suggest that we use that repo for demo scripts. (That repo will be renamed as kruize-demos as it will be housing demos for both autotune as well as hpoaas) |
@chandrams can you review from a test perspective, thanks |
@dinogun is the test suite working now? There are no explicit tests for this PR, but if the test-suite works, I can add them |
@johnaohara the testsuite is working now. To add a new test case into hpo test suite:
Then the test can be run using this command: |
Installed these modules - grpcio, google, google-api-core Deployed the HPO service and accessed it using the gRPC client as below
@khansaad - John mentioned this was due to using experiment_id to lookup rather than experiment_name. I think addressing #28 which is to replace experiment_id with experiment_name in HPO REST APIs will address this. |
Ok. |
@dinogun / @chandrams are there anything outstanding issues on this PR? |
@johnaohara as mentioned earlier, wanted to use |
@dinogun ok, I will rebase and fix any conflicts |
…o in docker for now as it fails
|
From the input API yes, as id is something that ideally should be generated by HPOaaS. The generated id in this case is a combination of trial_id and trial_num. |
Tested it manually changes look fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks a lot |
Thank you for helping HPO get off the ground! |
This PR introduces a gRPC service and an example command line client. The gRPC service uses the same hpo_service instance as the REST api, so running experiments are available simultaneously through both api's
This allows for greater integration possibilities with other tooling as the service protobuf is consumable via many different languages which allows for easy creation of HPO clients
Protobuf also handles message encoding/decoding and date type validation at the protocol level