Chacha20 poly1305 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change from aes256-gcm to chacha20 poly1305.
The primary reasoning behind this is that aes256-gcm has a 64GB limit per key or nonce [0].
i6 pack is primarily intended to be used for compressing and encrypting backups, and thus we will be hitting this 64GB limit.
We are not looking to increase complexity by implementing rotating keys / nonces, and thus other cipher suites were considered.
In looking for other available cipher suites, chacha20 poly1305 seems to cover most of the needs of this library, and thus is chosen.
0 - https://crypto.stackexchange.com/questions/31793/plain-text-size-limits-for-aes-gcm-mode-just-64gb