UI: Fix text color precedence in Text component #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksharma-xyz
changed the title
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ksharma-xyz
force-pushed
the
02-12-prefer_param_color_and_then_localcomposition_color
branch
from
c5cc3a5 to
3251804
Compare
ksharma-xyz
force-pushed
the
02-12-prefer_param_color_and_then_localcomposition_color
branch
from
3251804 to
82da464
Compare
ksharma-xyz
force-pushed
the
02-12-prefer_param_color_and_then_localcomposition_color
branch
from
82da464 to
4c76cf4
Compare
ksharma-xyz
deleted the
02-12-prefer_param_color_and_then_localcomposition_color
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Fixed text color precedence in Text component to prioritize explicitly provided colors over local text color.
What changed?
Reordered the color selection logic in the Text component to first check for explicitly provided colors before falling back to
LocalTextColor. If neither is specified, it defaults to the theme'sonSurfacecolor.How to test?
Why make this change?
The previous implementation incorrectly prioritized
LocalTextColorover explicitly provided colors, which could lead to unexpected text styling behavior. This change ensures that developer-specified colors take precedence, following standard composition principles.