Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Update check icon color in TimeTableScreen #612

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Feb 13, 2025

TL;DR

Added color tinting to the check icon in the TimeTableScreen's Done button

What changed?

Added a ColorFilter.tint() to the check icon image in the TimeTableScreen, using the foreground color derived from the current theme color

How to test?

  1. Navigate to the TimeTableScreen
  2. Verify that the check icon in the Done button matches the theme's foreground color
  3. Test with different theme colors to ensure proper contrast

Why make this change?

To ensure the check icon maintains proper visibility and consistency with the app's theme, particularly when different theme colors are applied

@ksharma-xyz ksharma-xyz changed the title Image color to be same as text color UI: Update check icon color in TimeTableScreen Feb 13, 2025
Copy link
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ksharma-xyz ksharma-xyz marked this pull request as ready for review February 13, 2025 02:23
Copy link
Owner Author

ksharma-xyz commented Feb 13, 2025

Merge activity

  • Feb 12, 11:31 PM EST: Graphite rebased this pull request as part of a merge.
  • Feb 12, 11:43 PM EST: A user merged this pull request with Graphite.

@ksharma-xyz ksharma-xyz merged commit 80832f9 into main Feb 13, 2025
2 checks passed
@ksharma-xyz ksharma-xyz deleted the 02-13-image_color_to_be_same_as_text_color branch February 13, 2025 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant