Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Bug fix analytics theme tracking #623

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Feb 17, 2025

Make loadKrailThemeStyle suspend instead of launching a new coroutine.

Otherwise trackAppStartEvent() will track wrong id for selected theme

Copy link
Owner Author

ksharma-xyz commented Feb 17, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ksharma-xyz ksharma-xyz changed the title BUG: make loadKrailThemeStyle suspend otherwise wrong theme id was being tracked by analytics. UI: Enhance theme loading and analytics logging Feb 17, 2025
@ksharma-xyz ksharma-xyz changed the title UI: Enhance theme loading and analytics logging UI: Bug fix analytics theme tracking Feb 17, 2025
@ksharma-xyz ksharma-xyz marked this pull request as ready for review February 17, 2025 22:08
Base automatically changed from 02-17-update_text to main February 18, 2025 20:56
@ksharma-xyz ksharma-xyz force-pushed the 02-18-bug_make_loadkrailthemestyle_suspend_otherwise_wrong_theme_id_was_being_tracked_by_analytics branch from c567655 to bf74c73 Compare February 20, 2025 06:32
@ksharma-xyz ksharma-xyz merged commit 77c2641 into main Feb 20, 2025
2 checks passed
@ksharma-xyz ksharma-xyz deleted the 02-18-bug_make_loadkrailthemestyle_suspend_otherwise_wrong_theme_id_was_being_tracked_by_analytics branch February 20, 2025 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant