KTOR-6671 Fix Resources: a / route isn't resolved when there is a sib… #4667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjhham
approved these changes
Feb 12, 2025
Comment on lines
+610
to
+613
| ) = createChild(object : RouteSelector() { | ||
| override suspend fun evaluate(context: RoutingResolveContext, segmentIndex: Int): RouteSelectorEvaluation = | ||
| RouteSelectorEvaluation.Success(quality = RouteSelectorEvaluation.qualityTailcard) | ||
| }).apply { |
There was a problem hiding this comment.
Extracting the selector here could help with readability. Something like:
createChild(TailcardSelector).apply { /* ... */ }
// Adds lower priority to the route so that it can be used as a fallback
object TailcardSelector : RouteSelector() {
override suspend fun evaluate(context: RoutingResolveContext, segmentIndex: Int): RouteSelectorEvaluation =
RouteSelectorEvaluation.Success(quality = RouteSelectorEvaluation.qualityTailcard)
}
There was a problem hiding this comment.
yep, but I want to avoid creating new API with the fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix KTOR-6671 Resources: a / route isn't resolved when there is a sibling
staticResources