kuring-101 피드백 보내기 화면 2.0 디자인 적용 #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwy3055
reviewed
Jan 23, 2024
feature/feedback/src/main/java/com/ku_stacks/ku_ring/feedback/feedback/FeedbackActivity.kt
Show resolved
Hide resolved
...ure/feedback/src/main/java/com/ku_stacks/ku_ring/feedback/feedback/compose/FeedbackScreen.kt
Outdated
Show resolved
Hide resolved
feature/feedback/src/main/java/com/ku_stacks/ku_ring/feedback/feedback/FeedbackViewModel.kt
Outdated
Show resolved
Hide resolved
...ure/feedback/src/main/java/com/ku_stacks/ku_ring/feedback/feedback/compose/FeedbackScreen.kt
Outdated
Show resolved
Hide resolved
...ure/feedback/src/main/java/com/ku_stacks/ku_ring/feedback/feedback/compose/FeedbackScreen.kt
Outdated
Show resolved
Hide resolved
...ure/feedback/src/main/java/com/ku_stacks/ku_ring/feedback/feedback/compose/FeedbackScreen.kt
Show resolved
Hide resolved
...ure/feedback/src/main/java/com/ku_stacks/ku_ring/feedback/feedback/compose/FeedbackScreen.kt
Outdated
Show resolved
Hide resolved
...ure/feedback/src/main/java/com/ku_stacks/ku_ring/feedback/feedback/compose/FeedbackScreen.kt
Outdated
Show resolved
Hide resolved
...ure/feedback/src/main/java/com/ku_stacks/ku_ring/feedback/feedback/compose/FeedbackScreen.kt
Outdated
Show resolved
Hide resolved
|
ci fail은 #86 가 머지되면 pass 될것입니다. 리뷰 끝나시면 뒤에꺼 머지할게요~! |
kuring-101 FeedbackViewModel unit test 수정, MainDispatcherRule 추가
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://kuring.atlassian.net/browse/KURING-101
변경 사항
Preview 만드는게 상당히 귀찮으면서도 어려운 일이더라구요..viewModel 객체를 만드는것이 주요 이슈였는데 preview에서 쉽게 구현하기 위해 viewModel interface를 활용해봤습니다.특이사항
피드백 보내기버튼이 짤리지않으면서 그 상단에 위치하도록 하는게 잘 되지않아서 그냥 남은 높이를 차지하도록 했어요. 약간 아쉬운데 혹시 아이디어 있으시면 의견 부탁드려요ScreenShot
Screen_recording_20240121_163201.mp4