Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update jsonpath-rust to remove lazy_static and once_cell dependencies, slight performance improvement #1629

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

bryantbiggs
Copy link
Contributor

Motivation

  • Removes the number of sub-dependencies and slightly improves performance

Solution

  • Update jsonpath-rust to remove lazy_static and once_cell dependencies

See diff besok/jsonpath-rust@v0.5...v0.7

image

@bryantbiggs bryantbiggs force-pushed the chore/update-jsonpath branch from 42affe1 to 600c60b Compare November 7, 2024 02:31
Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thank you!

@bryantbiggs
Copy link
Contributor Author

I'll fix the failing examples in the morning

@bryantbiggs bryantbiggs force-pushed the chore/update-jsonpath branch 3 times, most recently from 4035b28 to 55b5605 Compare November 11, 2024 01:52
@bryantbiggs bryantbiggs force-pushed the chore/update-jsonpath branch from 55b5605 to cbdda8d Compare November 11, 2024 01:53
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.3%. Comparing base (9c402a6) to head (cbdda8d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1629     +/-   ##
=======================================
+ Coverage   75.3%   75.3%   +0.1%     
=======================================
  Files         82      82             
  Lines       7348    7346      -2     
=======================================
  Hits        5528    5528             
+ Misses      1820    1818      -2     
Files with missing lines Coverage Δ
kube-client/src/api/entry.rs 79.7% <ø> (ø)
kube-client/src/client/auth/mod.rs 49.4% <100.0%> (+0.5%) ⬆️

@bryantbiggs
Copy link
Contributor Author

looks like the failed lint is because I haven't rebased off main to include #1636

@clux should I rebase and include this and then we re-run the tests or ok to assume that test is fine and fixed now on main?

@clux
Copy link
Member

clux commented Nov 12, 2024

All good. DW.

@clux clux merged commit b0538cb into kube-rs:main Nov 12, 2024
16 of 17 checks passed
@clux clux added this to the 0.97.0 milestone Nov 12, 2024
@clux clux added dependencies upgrades to dependencies changelog-exclude changelog excluded prs labels Nov 12, 2024
@bryantbiggs bryantbiggs deleted the chore/update-jsonpath branch November 12, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-exclude changelog excluded prs dependencies upgrades to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants