Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistencies in rustfmt editions on CI and local #1646

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

clux
Copy link
Member

@clux clux commented Nov 22, 2024

We should be using at least edition 2021 everywhere.

(Noticed in #1644)

Also allowlists a red deny error from two different version of rustls-native-certs, the oldest of which is pulled in by hyper-http-proxy.

We should be using at least edition 2021 everywhere.

Signed-off-by: clux <[email protected]>
@clux clux added the changelog-exclude changelog excluded prs label Nov 22, 2024
@clux clux added this to the 0.98.0 milestone Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.5%. Comparing base (08ccc47) to head (5e8341c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1646   +/-   ##
=====================================
  Coverage   75.5%   75.5%           
=====================================
  Files         82      82           
  Lines       7403    7403           
=====================================
  Hits        5589    5589           
  Misses      1814    1814           
---- 🚨 Try these New Features:

@clux clux marked this pull request as ready for review November 22, 2024 03:53
@clux clux merged commit fa7b7f2 into main Nov 22, 2024
17 checks passed
@clux clux deleted the fix-edition-inconsistencies branch November 22, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-exclude changelog excluded prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant