Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait combinators #678

Merged
merged 4 commits into from
Oct 26, 2021
Merged

Wait combinators #678

merged 4 commits into from
Oct 26, 2021

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Oct 26, 2021

As discussed in #669

@nightkr
Wait condition and/or/not combinators
abe6949 
Signed-off-by: Teo Klestrup Röijezon <[email protected]>
@nightkr
Combinator docs
2c8b0ce 
Signed-off-by: Teo Klestrup Röijezon <[email protected]>
@nightkr nightkr requested a review from clux October 26, 2021 12:30
@nightkr
Changelog
187f1d0 
Signed-off-by: Teo Klestrup Röijezon <[email protected]>
clux
clux approved these changes Oct 26, 2021
View reviewed changes
Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, impls on the Condition trait itself. That's nice. 👍

@nightkr
Copy link
Member Author

nightkr commented Oct 26, 2021

It would've been nice to overload & and | for this, but that doesn't work with trait coherency (since we have no idea whether the Fn already implements BitAnd or BitOr).

@nightkr nightkr merged commit 4eb11f7 into kube-rs:master Oct 26, 2021
@nightkr nightkr deleted the feature/wait-combinators branch October 26, 2021 13:31
@clux
Copy link
Member

clux commented Oct 26, 2021

technically this snuck in the patch release 0.63.1, but definitely not a breaking change anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clux clux clux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nightkr @clux