Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add linux/arm64 support for tf-operator image #1238

Merged
merged 1 commit into from
Jan 2, 2025
Merged

feat: add linux/arm64 support for tf-operator image #1238

merged 1 commit into from
Jan 2, 2025

Conversation

ChenYi015
Copy link
Collaborator

Purpose of this PR

Proposed changes:

  • Add support for multi-arch tf-operator image (linux/adm64,linux/arm64)

Change Category

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Rationale

@ChenYi015 ChenYi015 marked this pull request as ready for review January 2, 2025 06:03
@ChenYi015 ChenYi015 changed the title Add support for linux/arm64 tf-operator image feat: add linux/arm64 support for tf-operator image Jan 2, 2025
cheyang
cheyang approved these changes Jan 2, 2025
View reviewed changes
Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Jan 2, 2025
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 13fa5c8 into kubeflow:master Jan 2, 2025
5 checks passed
@ChenYi015 ChenYi015 deleted the update-tf-operator-image branch January 2, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheyang cheyang cheyang approved these changes

@wsxiaozhang wsxiaozhang Awaiting requested review from wsxiaozhang

@xiaozhouX xiaozhouX Awaiting requested review from xiaozhouX

Assignees

@cheyang cheyang

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChenYi015 @cheyang