update the job status api (#44)

kubeflow · Jun 19, 2019 · 09e1ac1 · 09e1ac1
1 parent c8c5b56
commit 09e1ac1
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/job_controller/api/v1/interface.go b/job_controller/api/v1/interface.go
@@ -38,7 +38,7 @@ type ControllerInterface interface {
 	DeleteJob(job interface{}) error
 
 	// UpdateJobStatus updates the job status and job conditions
-	UpdateJobStatus(job interface{}, replicas map[ReplicaType]*ReplicaSpec, jobStatus JobStatus) error
+	UpdateJobStatus(job interface{}, replicas map[ReplicaType]*ReplicaSpec, jobStatus *JobStatus) error
 
 	// UpdateJobStatusInApiServer updates the job status in API server
 	UpdateJobStatusInApiServer(job interface{}, jobStatus *JobStatus) error

diff --git a/job_controller/job.go b/job_controller/job.go
@@ -210,7 +210,7 @@ func (jc *JobController) ReconcileJobs(
 		}
 	}
 
-	err = jc.Controller.UpdateJobStatus(job, replicas, jobStatus)
+	err = jc.Controller.UpdateJobStatus(job, replicas, &jobStatus)
 	if err != nil {
 		log.Warnf("UpdateJobStatus error %v", err)
 		return err

diff --git a/job_controller/test_job_controller.go b/job_controller/test_job_controller.go
@@ -68,7 +68,7 @@ func (t *TestJobController) DeleteJob(job interface{}) error {
 }
 
 func (t TestJobController) UpdateJobStatus(job interface{}, replicas map[apiv1.ReplicaType]*apiv1.ReplicaSpec,
-	jobStatus apiv1.JobStatus) error {
+	jobStatus *apiv1.JobStatus) error {
 	return nil
 }
 

diff --git a/test_job/v1/test_job_controller.go b/test_job/v1/test_job_controller.go
@@ -68,7 +68,7 @@ func (t *TestJobController) DeleteJob(job interface{}) error {
 }
 
 func (t *TestJobController) UpdateJobStatus(job interface{}, replicas map[apiv1.ReplicaType]*apiv1.ReplicaSpec,
-	jobStatus apiv1.JobStatus) error {
+	jobStatus *apiv1.JobStatus) error {
 	return nil
 }