Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mprahl as a member to the Kubeflow org #732

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

mprahl
Copy link
Contributor

@mprahl mprahl commented Dec 20, 2024

Membership Request

Please read the guidelines for joining the Kubeflow GitHub org before opening an issue

Resolves #731.

Please provide links to PRs or other contributions (2-3):

kubeflow/pipelines#11443
kubeflow/pipelines#11459
kubeflow/pipelines#11470
kubeflow/pipelines#11015

Reviews:

kubeflow/pipelines#11475
kubeflow/pipelines#11469

Please list 2 existing members who are sponsoring your membership:

@HumairAK
@hbelmiro

Please test your PR

Run

cd github_orgs
pytest test_org_yaml.py

Include the output in the PR

internal-acls/github-orgs on  add-mprahl [?] via 🐍 v3.13.0 (internal-acls) ❯ pytest test_org_yaml.py
========================================================================= test session starts =========================================================================
platform linux -- Python 3.13.0, pytest-8.3.4, pluggy-1.5.0
rootdir: /home/mprahl/git/internal-acls/github-orgs
collected 1 item                                                                                                                                                      

test_org_yaml.py .                                                                                                                                              [100%]

========================================================================== 1 passed in 0.16s ==========================================================================

Additional Instructions

After your PR is merged please wait at least 1 hour for changes to propogate.

If after an hour you haven't recieved an invite to join the GitHub org please open an issue.

Copy link

Hi @mprahl. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mprahl
Copy link
Contributor Author

mprahl commented Dec 20, 2024

/cc @HumairAK @hbelmiro

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to sponsor @mprahl's membership.

/lgtm
/ok-to-test

@HumairAK
Copy link
Contributor

I am also more than happy to sponsor @mprahl !

/lgtm
/assign @terrytangyuan

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit f22efbd into kubeflow:master Dec 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add mprahl as a member to the Kubeflow org
4 participants