Reverted cmp to reflect

Signed-off-by: tariq-hasan <[email protected]>

pkg/controller.v1beta1/suggestion/composer/composer_test.go

@@ -22,12 +22,12 @@ import (
 	stdlog "log"
 	"os"
 	"path/filepath"
+	"reflect"
 	"strings"
 	"sync"
 	"testing"
 	"time"
 
-	"github.com/google/go-cmp/cmp"
 	"github.com/onsi/gomega"
 	"github.com/spf13/viper"
 	appsv1 "k8s.io/api/apps/v1"
@@ -631,8 +631,8 @@ func TestDesiredRBAC(t *testing.T) {
 func metaEqual(expected, actual metav1.ObjectMeta) bool {
 	return expected.Name == actual.Name &&
 		expected.Namespace == actual.Namespace &&
-		cmp.Equal(expected.Labels, actual.Labels) &&
-		cmp.Equal(expected.Annotations, actual.Annotations) &&
+		reflect.DeepEqual(expected.Labels, actual.Labels) &&
+		reflect.DeepEqual(expected.Annotations, actual.Annotations) &&
 		(len(actual.OwnerReferences) > 0 &&
 			expected.OwnerReferences[0].APIVersion == actual.OwnerReferences[0].APIVersion &&
 			expected.OwnerReferences[0].Kind == actual.OwnerReferences[0].Kind &&

pkg/suggestion/v1beta1/goptuna/converter.go

@@ -311,7 +311,7 @@ func toGoptunaParams(
 			}
 			ir := float64(p)
 			internalParams[name] = ir
-			// externalParams[name] = p is prohibited because of cmp.Diff() will not be empty
+			// externalParams[name] = p is prohibited because of reflect.DeepEqual() will be false
 			// at findGoptunaTrialIDByParam() function.
 			externalParams[name] = d.ToExternalRepr(ir)
 		case goptuna.StepIntUniformDistribution:
@@ -321,7 +321,7 @@ func toGoptunaParams(
 			}
 			ir := float64(p)
 			internalParams[name] = ir
-			// externalParams[name] = p is prohibited because of cmp.Diff() will not be empty
+			// externalParams[name] = p is prohibited because of reflect.DeepEqual() will be false
 			// at findGoptunaTrialIDByParam() function.
 			externalParams[name] = d.ToExternalRepr(ir)
 		case goptuna.CategoricalDistribution:

pkg/suggestion/v1beta1/goptuna/sample.go

@@ -18,10 +18,10 @@ package suggestion_goptuna_v1beta1
 
 import (
 	"fmt"
+	"reflect"
 	"strconv"
 
 	"github.com/c-bata/goptuna"
-	"github.com/google/go-cmp/cmp"
 	api_v1_beta1 "github.com/kubeflow/katib/pkg/apis/manager/v1beta1"
 )
 
@@ -119,9 +119,9 @@ func findGoptunaTrialIDByParam(study *goptuna.Study, trialMapping map[string]int
 			continue
 		}
 
-		if diff := cmp.Diff(ktrial.Params, trials[i].Params); diff == "" {
+		if reflect.DeepEqual(ktrial.Params, trials[i].Params) {
 			return trials[i].ID, nil
 		}
 	}
-	return -1, fmt.Errorf("same parameter is not found for Trial: %v", ktrial)
+	return -1, fmt.Errorf("Same parameter is not found for Trial: %v", ktrial)
 }