-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(trial): use propagated gomega to improve debuggability. #2432
fix(trial): use propagated gomega to improve debuggability. #2432
Conversation
Signed-off-by: Electronic-Waste <[email protected]>
/rerun-all |
I've replaced PTAL if you have time👀 @kubeflow/wg-automl-leads |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
/remove-lifecycle stale |
PTAL if you have time👀 @kubeflow/wg-automl-leads @tariq-hasan @helenxie-bit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, we can merge it. Thanks for this @Electronic-Waste!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
As I described in #2431, a propagated
gomega.Gomega
will improve the debuggability of the UTs.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #2431
Checklist: