Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(trial): use propagated gomega to improve debuggability. #2432

Merged

Conversation

Electronic-Waste
Copy link
Member

What this PR does / why we need it:

As I described in #2431, a propagated gomega.Gomega will improve the debuggability of the UTs.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2431

Checklist:

  • Docs included if any changes are user facing

@Electronic-Waste
Copy link
Member Author

/rerun-all

@Electronic-Waste
Copy link
Member Author

Electronic-Waste commented Sep 19, 2024

I've replaced func() bool with func(g gomega.Gomega) in the UTs of Trial Controller.

PTAL if you have time👀 @kubeflow/wg-automl-leads

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@Electronic-Waste
Copy link
Member Author

/remove-lifecycle stale

@Electronic-Waste
Copy link
Member Author

PTAL if you have time👀 @kubeflow/wg-automl-leads @tariq-hasan @helenxie-bit

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, we can merge it. Thanks for this @Electronic-Waste!
/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit eb8af4d into kubeflow:master Jan 10, 2025
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Debuggability in UTs of Trial Controller
2 participants