Skip to content
This repository has been archived by the owner on Aug 9, 2024. It is now read-only.

Add MPIJob to configurator #205

Merged
merged 5 commits into from
Jul 2, 2019
Merged

Conversation

Akado2009
Copy link
Contributor

@Akado2009 Akado2009 commented Jul 1, 2019

Partly addresses: #195


This change is Reviewable

Fix dependencies and packages (kubeflow#202)
@Akado2009
Copy link
Contributor Author

/retest

1 similar comment
@Akado2009
Copy link
Contributor Author

/retest

Copy link
Member

@xyhuang xyhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit

go.mod Outdated
@@ -1,6 +1,7 @@
module github.com/kubeflow/kubebench

require (
github.com/kubeflow/mpi-operator v0.0.0-20190629143922-c9c91b690f87
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please align this in alphabetical order?

@xyhuang
Copy link
Member

xyhuang commented Jul 2, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xyhuang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 57e266e into kubeflow:master Jul 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants