Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump requests-toolbelt to 1.1.0 fixes #10470 #10761

Closed
wants to merge 40 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
aa89b16
Change endpoint entrypoint
tristan-vt Dec 22, 2022
565383d
Fix method params
tristan-vt Dec 22, 2022
6a8690a
Typo
tristan-vt Dec 22, 2022
eaf8f7a
Fix encryption spec
tristan-vt Dec 22, 2022
943fd63
Typo
tristan-vt Dec 22, 2022
fd31995
Add endpoint name
tristan-vt Dec 22, 2022
7c860bb
Reorder params
tristan-vt Dec 22, 2022
dce2b82
Pass project and location as method
tristan-vt Dec 22, 2022
941173b
Restructure params
tristan-vt Dec 22, 2022
90e5f24
Fix typo
tristan-vt Dec 22, 2022
f56aee8
Fix typo
GiuliaMassimetti Dec 22, 2022
b725bd0
Merge branch 'chore/cleanup-gcp' of https://github.com/devoteamgcloud…
GiuliaMassimetti Dec 22, 2022
4852c75
Remove network
tristan-vt Dec 22, 2022
063ee51
Merge branch 'chore/cleanup-gcp' of github.com:devoteamgcloud/pipelin…
tristan-vt Dec 22, 2022
e4c6ac9
Change command and arguments
GiuliaMassimetti Dec 29, 2022
c5d593b
Specify project, location and endpoint name
GiuliaMassimetti Dec 29, 2022
8e30424
Formatting and type annotations
GiuliaMassimetti Dec 29, 2022
1be2d4d
Changed inputUri to inputPath
GiuliaMassimetti Dec 29, 2022
bb91c17
Changed model input
GiuliaMassimetti Dec 29, 2022
6cba55a
Add debug logs
GiuliaMassimetti Dec 29, 2022
3024430
Add warnings for debug
GiuliaMassimetti Dec 29, 2022
a3bb27b
Removed explanation parameters and metadata
GiuliaMassimetti Dec 29, 2022
e928480
Remove warnings and traffic split in deployment
GiuliaMassimetti Dec 29, 2022
3975da8
Add try catch for model resourceName
GiuliaMassimetti Dec 29, 2022
16c0b92
Change container image to test remote_runner modifications
GiuliaMassimetti Dec 30, 2022
0cc521f
Removed quotes from endpoint and model name
GiuliaMassimetti Dec 30, 2022
95e15c9
Added conditional parameters
GiuliaMassimetti Dec 30, 2022
7265396
Add parameters to deploy op and change container image
GiuliaMassimetti Dec 30, 2022
00efea0
Refactor delete_endpoint
GiuliaMassimetti Jan 2, 2023
6302b98
Added executor_input
GiuliaMassimetti Jan 2, 2023
0d6cc6e
Changed method from Endpoint.deploy to Model.deploy
GiuliaMassimetti Jan 3, 2023
5155cd2
Put optional parameter in conditional block
GiuliaMassimetti Jan 3, 2023
54df9ee
Add Endpoint output
GiuliaMassimetti Jan 3, 2023
d697fc3
Updated description and moved deploy_model to Model folder
GiuliaMassimetti Jan 4, 2023
0093f9d
Merge branch 'kubeflow:master' into chore/cleanup-gcp
GiuliaMassimetti Jan 4, 2023
a462a91
Merge pull request #1 from devoteamgcloud/chore/cleanup-gcp
GiuliaMassimetti Jan 4, 2023
a5d8464
Refactor tests
GiuliaMassimetti Jan 5, 2023
7fd19c6
Merge branch 'master' of https://github.com/devoteamgcloud/pipelines
GiuliaMassimetti Jan 5, 2023
2202e5a
Merge branch 'kubeflow:master' into master
GiuliaMassimetti Jan 5, 2023
e09da2f
bump requests-toolbelt to 1.1.0
SimonDR-Boltzmann Apr 29, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@

ModelDeployOp = load_component_from_file(
os.path.join(
os.path.dirname(__file__), 'endpoint/deploy_model/component.yaml'))
os.path.dirname(__file__), 'model/deploy_model/component.yaml'))

ModelUndeployOp = load_component_from_file(
os.path.join(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ description: |
Required. Project to create the endpoint.
location (Optional[str]):
Location to create the endpoint. If not set, default to us-central1.
endpoint_name (str):
Required. The resource name of the Endpoint.
display_name (str):
Required. The user-defined name of the Endpoint.
The name can be up to 128 characters long and can be consist
Expand All @@ -33,14 +35,6 @@ description: |
resource is created.

If set, this Endpoint and all sub-resources of this Endpoint will be secured by this key.
network (Optional[str]):
The full name of the Google Compute Engine network to which the
Endpoint should be peered. Private services access must already be configured for
the network. If left unspecified, the Endpoint is not peered with any network.

[Format](https://cloud.google.com/compute/docs/reference/rest/v1/networks/insert):
projects/{project}/global/networks/{network}.
Where {project} is a project number, as in '12345', and {network} is network name.
Returns:
endpoint (google.VertexEndpoint):
Artifact tracking the created endpoint.
Expand All @@ -51,32 +45,47 @@ description: |
inputs:
- {name: project, type: String}
- {name: location, type: String, default: "us-central1"}
- {name: endpoint_name, type: String}
- {name: display_name, type: String}
- {name: description, type: String, optional: true, default: ''}
- {name: labels, type: JsonObject, optional: true, default: '{}'}
- {name: encryption_spec_key_name, type: String, optional: true, default: ''}
- {name: network, type: String, optional: true, default: ''}
- {name: encryption_spec_key_name, type: String, optional: true}
outputs:
- {name: endpoint, type: google.VertexEndpoint}
- {name: gcp_resources, type: String}
implementation:
container:
image: gcr.io/ml-pipeline/google-cloud-pipeline-components:latest
command: [python3, -u, -m, google_cloud_pipeline_components.container.v1.endpoint.create_endpoint.launcher]
args: [
--type, CreateEndpoint,
--payload,
concat: [
'{',
'"display_name": "', {inputValue: display_name}, '"',
', "description": "', {inputValue: description}, '"',
', "labels": ', {inputValue: labels},
', "encryption_spec": {"kms_key_name":"', {inputValue: encryption_spec_key_name}, '"}',
', "network": "', {inputValue: network}, '"',
'}'
],
--project, {inputValue: project},
--location, {inputValue: location},
--gcp_resources, {outputPath: gcp_resources},
--executor_input, "{{$}}",
]
command: [python3, -u, -m, google_cloud_pipeline_components.container.aiplatform.remote_runner, --cls_name, Endpoint, --method_name, create]
args:
- --init.project
- {inputValue: project}
- --init.location
- {inputValue: location}
- --init.endpoint_name
- {inputValue: endpoint_name}
- --method.project
- {inputValue: project}
- --method.location
- {inputValue: location}
- --method.display_name
- {inputValue: display_name}
- if:
cond: {isPresent: description}
then:
- --method.description
- {inputValue: description}
- if:
cond: {isPresent: labels}
then:
- --method.labels
- {inputValue: labels}
- if:
cond: {isPresent: encryption_spec_key_name}
then:
- --method.encryption_spec_key_name
- {inputValue: encryption_spec_key_name}
- --gcp_resources
- {outputPath: gcp_resources}
- --executor_input
- "{{$}}"
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ description: |
Args:
endpoint (google.VertexEndpoint):
Required. The endpoint to be deleted.
force (Optional[bool]):
Optional. If force is set to True, all deployed models on this Endpoint will be undeployed first. Default is False.
sync (Optional[bool]):
Optional. Whether to execute this method synchronously.

Returns:
gcp_resources (str):
Expand All @@ -14,21 +18,28 @@ description: |
For more details, see https://github.com/kubeflow/pipelines/blob/master/components/google-cloud/google_cloud_pipeline_components/proto/README.md.
inputs:
- {name: endpoint, type: google.VertexEndpoint}
- {name: force, type: Boolean, optional: true, default: False}
- {name: sync, type: Boolean, optional: true, default: True}
outputs:
- {name: gcp_resources, type: String}
implementation:
container:
image: gcr.io/ml-pipeline/google-cloud-pipeline-components:latest
command: [python3, -u, -m, google_cloud_pipeline_components.container.v1.endpoint.delete_endpoint.launcher]
args: [
--type, DeleteEndpoint,
--payload,
concat: [
'{',
'"endpoint": "', "{{$.inputs.artifacts['endpoint'].metadata['resourceName']}}", '"',
'}'
],
--project, '', # not being used
--location, '', # not being used
--gcp_resources, {outputPath: gcp_resources},
]
command: [python3, -u, -m, google_cloud_pipeline_components.container.aiplatform.remote_runner, --cls_name, Endpoint, --method_name, delete]
args:
- --init.endpoint_name
- "{{$.inputs.artifacts['endpoint'].metadata['resourceName']}}"
- if:
cond: {isPresent: force}
then:
- --method.force
- {inputValue: force}
- if:
cond: {isPresent: sync}
then:
- --method.sync
- {inputValue: sync}
- --gcp_resources,
- {outputPath: gcp_resources}
- --executor_input
- "{{$}}"

This file was deleted.

Loading