-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Added support for Python 3.13 to tests #11376
Conversation
Skipping CI for Draft Pull Request. |
2759298
to
b24ae1c
Compare
From SDK side, kfp-pipeline-spec is blocking Python 3.13 support. I sent a PR: #11378, PTAL.
No, I think it would be unnecessary and waste of resource to run all e2e or backend-integration tests with different Python versions. If we think SDK's main role as a YAML generator, as long as the produced YAML file doesn't change across Python versions--the SDK unit test guarantees that--they would work on the backend. |
ef99a6a
to
e084e8d
Compare
d18b0f7
to
4a0fb0a
Compare
Signed-off-by: Helber Belmiro <[email protected]>
4a0fb0a
to
99a00ee
Compare
@chensun I reverted the changes to add 3.13 to all tests and left 3.13 only on those tests that use all Python versions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of your changes:
This PR adds support for Python 3.13 to tests. This is a follow-up for #11372
Checklist: