Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Added support for Python 3.13 to tests #11376

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

hbelmiro
Copy link
Contributor

Description of your changes:
This PR adds support for Python 3.13 to tests. This is a follow-up for #11372

Checklist:

Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@hbelmiro
Copy link
Contributor Author

hbelmiro commented Nov 14, 2024

@chensun we have several tests failing with Python 3.13. Can you please take a look?
Also, I think we should have all tests using at least the minor and major supported Python versions (3.9 and 3.13).

cc @DharmitD @HumairAK

@chensun
Copy link
Member

chensun commented Nov 14, 2024

@chensun we have several tests failing with Python 3.13. Can you please take a look?

From SDK side, kfp-pipeline-spec is blocking Python 3.13 support. I sent a PR: #11378, PTAL.

Also, I think we should have all tests using at least the minor and major supported Python versions (3.9 and 3.13).

No, I think it would be unnecessary and waste of resource to run all e2e or backend-integration tests with different Python versions. If we think SDK's main role as a YAML generator, as long as the produced YAML file doesn't change across Python versions--the SDK unit test guarantees that--they would work on the backend.

@hbelmiro hbelmiro force-pushed the py313-tests branch 4 times, most recently from ef99a6a to e084e8d Compare November 18, 2024 15:34
@google-oss-prow google-oss-prow bot added size/S and removed size/L labels Nov 18, 2024
@hbelmiro hbelmiro force-pushed the py313-tests branch 2 times, most recently from d18b0f7 to 4a0fb0a Compare November 18, 2024 15:36
@google-oss-prow google-oss-prow bot added size/XS and removed size/S labels Nov 18, 2024
@github-actions github-actions bot added ci-passed All CI tests on a pull request have passed and removed ci-passed All CI tests on a pull request have passed labels Nov 18, 2024
@hbelmiro hbelmiro marked this pull request as ready for review November 18, 2024 15:42
@google-oss-prow google-oss-prow bot requested a review from HumairAK November 18, 2024 15:42
@github-actions github-actions bot removed the ci-passed All CI tests on a pull request have passed label Nov 18, 2024
@github-actions github-actions bot added the ci-passed All CI tests on a pull request have passed label Nov 18, 2024
@hbelmiro
Copy link
Contributor Author

@chensun I reverted the changes to add 3.13 to all tests and left 3.13 only on those tests that use all Python versions.
Can you please review?

@github-actions github-actions bot added ci-passed All CI tests on a pull request have passed and removed ci-passed All CI tests on a pull request have passed labels Nov 18, 2024
Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks!

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit c57e897 into kubeflow:master Nov 19, 2024
13 checks passed
@hbelmiro hbelmiro deleted the py313-tests branch November 19, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed All CI tests on a pull request have passed lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants