fix(sdk): Backport fixes in kubeflow/pipelines#11075 #11392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rimolive
force-pushed
the
cpu_memory_requests_limits
branch
from
df40f68 to
b8b72fe
Compare
rimolive
force-pushed
the
cpu_memory_requests_limits
branch
6 times, most recently
from
02daafe to
e11eb4c
Compare
rimolive
force-pushed
the
cpu_memory_requests_limits
branch
from
e11eb4c to
bc62bfd
Compare
rimolive
force-pushed
the
cpu_memory_requests_limits
branch
from
bc62bfd to
848b614
Compare
github-actions
bot
added
the
ci-passed
rimolive
force-pushed
the
cpu_memory_requests_limits
branch
3 times, most recently
from
293792f to
c669a7b
Compare
github-actions
bot
added
ci-passed
HumairAK
reviewed
Nov 24, 2024
|
Thanks @rimolive can you also add this change to: https://github.com/kubeflow/pipelines/blob/master/sdk/RELEASE.md#bug-fixes-and-other-changes? otherwise lgtm |
rimolive
force-pushed
the
cpu_memory_requests_limits
branch
from
c669a7b to
fe17f23
Compare
github-actions
bot
removed
the
ci-passed
github-actions
bot
added
the
ci-passed
rimolive
force-pushed
the
cpu_memory_requests_limits
branch
from
fe17f23 to
8ea2606
Compare
github-actions
bot
added
ci-passed
|
@chensun PTAL when you have the chance, this is another api breaking change that was introduced in 2.10 |
Introduced back the functions to convert k8s size values to float, but moved to kfp.dsl.utils Signed-off-by: Ricardo M. Oliveira <[email protected]>
rimolive
force-pushed
the
cpu_memory_requests_limits
branch
from
8ea2606 to
54074ac
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HumairAK The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced back the functions to convert k8s size values to float, but moved to kfp.dsl.utils
Description of your changes:
fixes #11390
Checklist: