Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(backend): Fixed ServiceAccount in job creation #11481

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

hbelmiro
Copy link
Contributor

@hbelmiro hbelmiro commented Dec 20, 2024

When creating recurring runs, the ScheduledWorkflow CR is created with no ServiceAccount set.
This PR fixes that.

Checklist:

Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@google-oss-prow google-oss-prow bot added size/M and removed size/S labels Dec 20, 2024
@hbelmiro hbelmiro marked this pull request as ready for review December 20, 2024 17:52
@rimolive
Copy link
Member

/lgtm

Copy link
Contributor

@mprahl mprahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hbelmiro
Copy link
Contributor Author

@HumairAK can you PTAL?

@HumairAK
Copy link
Collaborator

HumairAK commented Jan 8, 2025

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK, mprahl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 2686e01 into kubeflow:master Jan 8, 2025
33 checks passed
@hbelmiro hbelmiro deleted the fix-swf-sa branch January 8, 2025 14:06
hbelmiro added a commit to hbelmiro/data-science-pipelines that referenced this pull request Jan 9, 2025
Signed-off-by: Helber Belmiro <[email protected]>
(cherry picked from commit 2686e01)
hbelmiro added a commit to hbelmiro/data-science-pipelines that referenced this pull request Jan 16, 2025
Signed-off-by: Helber Belmiro <[email protected]>
(cherry picked from commit 2686e01)
hbelmiro added a commit to hbelmiro/data-science-pipelines that referenced this pull request Jan 17, 2025
Signed-off-by: Helber Belmiro <[email protected]>
(cherry picked from commit 2686e01)
(cherry picked from commit 37c74b3)
hbelmiro added a commit to hbelmiro/data-science-pipelines that referenced this pull request Jan 17, 2025
Signed-off-by: Helber Belmiro <[email protected]>
(cherry picked from commit 2686e01)
(cherry picked from commit 37c74b3)
hbelmiro added a commit to hbelmiro/data-science-pipelines that referenced this pull request Jan 23, 2025
hbelmiro added a commit to hbelmiro/data-science-pipelines that referenced this pull request Jan 23, 2025
hbelmiro added a commit to hbelmiro/data-science-pipelines that referenced this pull request Jan 23, 2025
hbelmiro added a commit to hbelmiro/data-science-pipelines that referenced this pull request Jan 23, 2025
mprahl pushed a commit to opendatahub-io/data-science-pipelines that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants