-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docs): Add architecture diagram #11490
base: master
Are you sure you want to change the base?
feat(docs): Add architecture diagram #11490
Conversation
c93651e
to
45cf652
Compare
@hbelmiro thanks for the review. I've made some updates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Signed-off-by: Anish Asthana <[email protected]>
45cf652
to
bcb8849
Compare
/lgtm |
bcb8849
to
7770ba4
Compare
/lgtm |
Signed-off-by: Anish Asthana <[email protected]>
Signed-off-by: Anish Asthana <[email protected]>
7770ba4
to
02c16bd
Compare
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rimolive The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[#kubeflow-pipelines](https://kubeflow.slack.com) | ||
We also have a slack channel (#kubeflow-pipelines) on the Cloud Native Computing Foundation Slack workspace. You can find more details at [https://www.kubeflow.org/docs/about/community/#kubeflow-slack-channels](https://www.kubeflow.org/docs/about/community/#kubeflow-slack-channels) | ||
|
||
## Architecture |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should put the arch diagram in the front readme of the repo, can we move this further into the docs folder? https://github.com/kubeflow/pipelines/tree/master/docs
once done we can link it from the kfp website in the operator-guides section: https://www.kubeflow.org/docs/components/pipelines/operator-guides/
Closes #10957
This is a first draft of an architecture diagram for Kubeflow Pipelines. I started with mermaid-js but it was taking a long while... I figured we can get something via draw.io diagram and then iterate over time.
cc @HumairAK