Update e2e tests

Signed-off-by: Yi Chen <[email protected]>
kubeflow · Jul 5, 2024 · 71a7ed7 · 71a7ed7
1 parent 3a60eb6
commit 71a7ed7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/test/e2e/sparkapplication_test.go b/test/e2e/sparkapplication_test.go
@@ -145,7 +145,7 @@ var _ = Describe("Example SparkApplication", func() {
 			}
 		})
 
-		It("should complete successfully", func() {
+		It("Should complete successfully", func() {
 			By("Waiting for SparkApplication to complete")
 			key := types.NamespacedName{Namespace: app.Namespace, Name: app.Name}
 			cancelCtx, cancelFunc := context.WithTimeout(ctx, WaitTimeout)
@@ -194,7 +194,7 @@ var _ = Describe("Example SparkApplication", func() {
 			Expect(k8sClient.Delete(ctx, app)).To(Succeed())
 		})
 
-		It("should complete successfully", func() {
+		It("Should complete successfully", func() {
 			By("Waiting for SparkApplication to complete")
 			key := types.NamespacedName{Namespace: app.Namespace, Name: app.Name}
 			cancelCtx, cancelFunc := context.WithTimeout(ctx, WaitTimeout)
@@ -243,7 +243,7 @@ var _ = Describe("Example SparkApplication", func() {
 			Expect(k8sClient.Delete(ctx, app)).To(Succeed())
 		})
 
-		It("should complete successfully", func() {
+		It("Should complete successfully", func() {
 			By("Waiting for SparkApplication to complete")
 			key := types.NamespacedName{Namespace: app.Namespace, Name: app.Name}
 			cancelCtx, cancelFunc := context.WithTimeout(ctx, WaitTimeout)

diff --git a/test/e2e/suit_test.go b/test/e2e/suit_test.go
@@ -147,7 +147,7 @@ var _ = AfterSuite(func() {
 	uninstallAction.Timeout = 5 * time.Minute
 	resp, err := uninstallAction.Run(ReleaseName)
 	Expect(err).To(BeNil())
-	Expect(resp).To(BeNil())
+	Expect(resp).NotTo(BeNil())
 
 	By("Deleting release namespace")
 	namespace := &corev1.Namespace{ObjectMeta: metav1.ObjectMeta{Name: ReleaseNamespace}}