Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XGBoost and MPI on homepage #1923

Merged
merged 1 commit into from
Apr 23, 2020
Merged

Add XGBoost and MPI on homepage #1923

merged 1 commit into from
Apr 23, 2020

Conversation

terrytangyuan
Copy link
Member

@terrytangyuan terrytangyuan commented Apr 23, 2020

Also change "MXNet" to "Apache MXNet"

@kubeflow-bot
Copy link

This change is Reviewable

@janeman98
Copy link
Contributor

Thanks @terrytangyuan !
/lgtm

For XGBoost, it is currently pointing to GitHub, will you consider adding a page in https://www.kubeflow.org/docs/components/training/ ?

@terrytangyuan
Copy link
Member Author

@janeman98 Yes, it will be done as part of kubeflow/xgboost-operator#44 for API reference/docs.

@sarahmaddox
Copy link
Contributor

Thanks @terrytangyuan and @janeman98! FYI, here's the doc issue for XGBoost: #866

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sarahmaddox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 422765a into master Apr 23, 2020
@terrytangyuan terrytangyuan deleted the terrytangyuan-patch-1 branch April 23, 2020 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants