Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some How-Tos i found helpful #109

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Some How-Tos i found helpful #109

wants to merge 2 commits into from

Conversation

hc2p
Copy link
Contributor

@hc2p hc2p commented Nov 1, 2023

What this PR does / why we need it:
I had to do some chores which were quite cumbersome. I hope these will help future me and others.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@kubermatic-bot kubermatic-bot added the dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. label Nov 1, 2023
@kubermatic-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign toschneck for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 1, 2023
toschneck
toschneck reviewed Nov 14, 2023
View reviewed changes
Copy link
Member

@toschneck toschneck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hc2p I have maybe a small improvement with the use of the mc container

knowledge-base/how-to-migrate-minio-storage.md
kubectl -n minio apply -f pvc.yaml
```

## Start debug container on cluster
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could use directly the minio image as well, I using locally ofte

docker run --rm -it --network host -v "`PWD`":/data -e MC_HOST_minio=https://___ACCESS__KEX___:[email protected] --name run-2-mc --entrypoint bash minio/mc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, i tried it but struggled to get into a shell, which is actually more convenient to do all the steps. Would be much better than needing to install something

knowledge-base/how-to-migrate-minio-storage.md
## Setup alias

```bash
mc alias set ALIAS http://minio:9000 <access-key> <access-secret>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

se above example could also get injected via env var ... just FYI

@toschneck
Copy link
Member

@hc2p I would suggest we directly move this to our docs under https://docs.kubermatic.com/kubermatic/main/cheat-sheets/
What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toschneck toschneck toschneck left review comments

Assignees

@hc2p hc2p

Labels
dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hc2p @kubermatic-bot @toschneck