-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix proxy tests #2126
Fix proxy tests #2126
Conversation
@cjihrig should I create PR for main or release-1.x? |
Please target main. |
/approve |
/lgtm cancel |
/test ? |
@cjihrig: No presubmit jobs available for kubernetes-client/javascript@main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
I don't appear to have permission to trigger the CI yet. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anandfresh, cjihrig, krmodelski The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@cjihrig I don't think If you can't see that button we probably need to add you in the repo settings somewhere. |
Yea, I have seen that button in other repos. I think the issue is that I am a member of the kubernetes-client org, but don't have any actual permissions in this repo. |
/lgtm |
Fix proxy tests added in this PR.