Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix proxy tests #2126

Merged

Conversation

krmodelski
Copy link
Contributor

Fix proxy tests added in this PR.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 25, 2024
@krmodelski
Copy link
Contributor Author

@cjihrig should I create PR for main or release-1.x?

@cjihrig
Copy link
Contributor

cjihrig commented Dec 25, 2024

Please target main.

@krmodelski krmodelski mentioned this pull request Dec 25, 2024
@krmodelski krmodelski changed the base branch from release-1.x to main December 25, 2024 20:36
@cjihrig
Copy link
Contributor

cjihrig commented Dec 25, 2024

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 25, 2024
@cjihrig
Copy link
Contributor

cjihrig commented Dec 25, 2024

/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 25, 2024
@cjihrig
Copy link
Contributor

cjihrig commented Dec 25, 2024

/test ?

@k8s-ci-robot
Copy link
Contributor

@cjihrig: No presubmit jobs available for kubernetes-client/javascript@main

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cjihrig
Copy link
Contributor

cjihrig commented Dec 25, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Dec 25, 2024
@cjihrig
Copy link
Contributor

cjihrig commented Dec 25, 2024

I don't appear to have permission to trigger the CI yet.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anandfresh, cjihrig, krmodelski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@brendandburns
Copy link
Contributor

@cjihrig I don't think /ok-to-test works for tests that use github actions instead of prow. There's a button down in the "review requested" section which enables testing.

If you can't see that button we probably need to add you in the repo settings somewhere.

@cjihrig
Copy link
Contributor

cjihrig commented Dec 27, 2024

Yea, I have seen that button in other repos. I think the issue is that I am a member of the kubernetes-client org, but don't have any actual permissions in this repo.

@cjihrig
Copy link
Contributor

cjihrig commented Dec 27, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 27, 2024
@k8s-ci-robot k8s-ci-robot merged commit 27ba0e1 into kubernetes-client:main Dec 27, 2024
8 checks passed
@krmodelski krmodelski deleted the proxy-support-test-fix branch December 28, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants