Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for allowWatchBookmarks to the dynamic client #2317

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anvilpete
Copy link

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • There's currently no way to pass allow_watch_bookmark to the dynamic client's watch method. This PR adds this parameter.

  • the allowWatchBookmarks query parameter is currently never set. This PR sets it based on the allow_watch_bookmarks keyword arg.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Added support for allowWatchBookmarks to the dynamic client

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 8, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anvilpete
Once this PR has been reviewed and has the lgtm label, please assign yliaog for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 8, 2025
@anvilpete
Copy link
Author

There's some evidence in the commit/issue/PR history that people have been managing to enable watch bookmarks. But I'm not sure how this is possible without setting the allowWatchBookmarks query parameter.

But in any case, this PR makes it possible.

@yliaog
Copy link
Contributor

yliaog commented Jan 8, 2025

/assign @fabianvf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants