test: e2e cover clusterclass provisioning #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
size/L
✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
salasberryfin
force-pushed
the
test-e2e-cover-clusterclass
branch
2 times, most recently
from
9ed9287 to
73c5f8d
Compare
Signed-off-by: Carlos Salas <[email protected]>
Signed-off-by: Carlos Salas <[email protected]>
salasberryfin
force-pushed
the
test-e2e-cover-clusterclass
branch
from
7961037 to
213b32f
Compare
|
/retest |
salasberryfin
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
salasberryfin
changed the title
|
Could you take a look at this old PR? It would be great to have |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, salasberryfin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind feature
What this PR does / why we need it:
Cover cluster provisioning via
ClusterClassin E2E tests.Which issue(s) this PR fixes:
Fixes #1354
Special notes for your reviewer:
To simplify the creation of all resources, this combines
ClusterClassandClusterdefinition together in a single yaml file. This allows us to provision all resources with only one apply command. Additionally, a new folder is created insidetest/e2e/data/to contain cluster class templates (this could be extended to other templates as the number of files keeps growing).TODOs:
Release note: