test: clean up wanterr logic to be more readable as an assert

Signed-off-by: Chris Privitere <[email protected]>
kubernetes-sigs · May 24, 2024 · 4ca3b76 · 4ca3b76
1 parent ad4b492
commit 4ca3b76
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/internal/emlb/emlb_test.go b/internal/emlb/emlb_test.go
@@ -167,11 +167,12 @@ func Test_getExternalIPv4Target(t *testing.T) {
 		t.Run(tt.name, func(t *testing.T) {
 			g := NewWithT(t)
 			got, err := getExternalIPv4Target(tt.args.deviceAddr)
-			if (err != nil) != tt.wantErr {
-				g.Expect(err).To(Equal(tt.wantErr))
-				return
+			if tt.wantErr {
+				g.Expect(err).To(HaveOccurred())
+			} else {
+				g.Expect(err).ToNot(HaveOccurred())
+				g.Expect(got).To(Equal(tt.want))
 			}
-			g.Expect(got).To(Equal(tt.want))
 		})
 	}
 }