Merge pull request #11661 from sbueringer/pr-hook-msg

🌱 Fix formatting of blocking lifecycle hook condition message
kubernetes-sigs · Jan 10, 2025 · 5a7ab0b · 5a7ab0b
2 parents da04ac5 + dcede42
commit 5a7ab0b
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/exp/topology/scope/hookresponsetracker.go b/exp/topology/scope/hookresponsetracker.go
@@ -91,7 +91,11 @@ func (h *HookResponseTracker) AggregateMessage() string {
 
 	hookAndMessages := []string{}
 	for hook, message := range blockingHooks {
-		hookAndMessages = append(hookAndMessages, fmt.Sprintf("hook %q is blocking: %s", hook, message))
+		if message == "" {
+			hookAndMessages = append(hookAndMessages, fmt.Sprintf("hook %q is blocking", hook))
+		} else {
+			hookAndMessages = append(hookAndMessages, fmt.Sprintf("hook %q is blocking: %s", hook, message))
+		}
 	}
 	return strings.Join(hookAndMessages, "; ")
 }