Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add release-1.6 branch to the github workflows #9756

Closed

Conversation

nawazkh
Copy link
Member

@nawazkh nawazkh commented Nov 21, 2023

What this PR does / why we need it:
This PR updates github workflows to include release-1.6 branch and drops release-1.4 branch

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes # N/A

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Nov 21, 2023
@k8s-ci-robot
Copy link
Contributor

This PR is currently missing an area label, which is used to identify the modified component when generating release notes.

Area labels can be added by org members by writing /area ${COMPONENT} in a comment

Please see the labels list for possible areas.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 21, 2023
@nawazkh
Copy link
Member Author

nawazkh commented Nov 21, 2023

Hold until release-1.6 branch exists.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 21, 2023
@nawazkh
Copy link
Member Author

nawazkh commented Nov 21, 2023

For continuity of context, if a reviewer is approving this PR, please also take a look at kubernetes/test-infra#31208

@sbueringer
Copy link
Member

/lgtm
/approve

(+/- pr tiltle / area)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 47e52faa814752483e2777a6a64ef041294a7d35

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2023
@nawazkh
Copy link
Member Author

nawazkh commented Nov 22, 2023

(+/- pr tiltle / area)

I can update this, not sure which area this PR belongs to?
And by "title", shall I be updating the title to something else?

@nawazkh
Copy link
Member Author

nawazkh commented Nov 22, 2023

Looks like #9708 has already been merged achieving the same.
/close

@k8s-ci-robot
Copy link
Contributor

@nawazkh: Closed this PR.

In response to this:

Looks like #9708 has already been merged achieving the same.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nawazkh nawazkh deleted the relase-1.6-misc-updates branch November 22, 2023 12:52
@sbueringer
Copy link
Member

Please try to avoid duplicate PRs in the future, I think we had a similar duplicate one in test-infra :)

@sbueringer
Copy link
Member

I can update this, not sure which area this PR belongs to? And by "title", shall I be updating the title to something else?

I guess area/release or something :), Without an icon as a prefix the GitHub check won't succeed in general

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/needs-area PR is missing an area label lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants