Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create pr-practice #1683

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Create pr-practice #1683

merged 2 commits into from
Feb 3, 2025

Conversation

Udi-Hofesh
Copy link
Member

Following advice from veteran contributors, I'm practicing submitting a pull request to the project.

-->

NONE

Following advice from veteran contributors, I'm practicing submitting a pull request to the project.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 31, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 31, 2025
@shu-mutou
Copy link
Contributor

please change filename to <your-github-account-name>.md

@shu-mutou
Copy link
Contributor

Also, fill PR template.
Sample PR is here.

@Udi-Hofesh
Copy link
Member Author

What type of PR is this?

/kind documentation

What this PR does / why we need it:
add udi-hofesh.md to remote/learners folder for practicing PR submission.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
NONE

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Feb 3, 2025
@shu-mutou
Copy link
Contributor

What type of PR is this?

/kind documentation

What this PR does / why we need it: add udi-hofesh.md to remote/learners folder for practicing PR submission.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?: NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: NONE

You can edit first PR comment from here.
Screenshot from 2025-02-04 08-38-32

Do so next time, thanks!

/lgtm
/approve
Welcome to K8s community 🎉

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shu-mutou, Udi-Hofesh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Feb 3, 2025
@k8s-ci-robot k8s-ci-robot merged commit a352c9a into kubernetes-sigs:master Feb 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants