Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #1514: fix: github action Release Charts to have write permissions #1559

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Automated cherry pick of #1514: fix: github action Release Charts to have write permissions #1559

merged 1 commit into from
Nov 20, 2024

Conversation

a7i
Copy link
Contributor

@a7i a7i commented Nov 20, 2024

Cherry pick of #1514 on release-1.30.

#1514: fix: github action Release Charts to have write permissions

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 20, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 20, 2024
@a7i
Copy link
Contributor Author

a7i commented Nov 20, 2024

/cc @damemi

release of 0.30.2 failed https://github.com/kubernetes-sigs/descheduler/actions/runs/11935638300/job/33267413863

Error: error creating GitHub release: POST https://api.github.com/repos/kubernetes-sigs/descheduler/releases: 403 Resource not accessible by integration []

@k8s-ci-robot k8s-ci-robot requested a review from damemi November 20, 2024 14:57
damemi
damemi approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 20, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2024
@k8s-ci-robot k8s-ci-robot merged commit e5c7c7a into kubernetes-sigs:release-1.30 Nov 20, 2024
9 checks passed
@a7i a7i deleted the automated-cherry-pick-of-#1514-upstream-release-1.30 branch November 20, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damemi damemi damemi approved these changes

@ingvagabund ingvagabund Awaiting requested review from ingvagabund

@seanmalloy seanmalloy Awaiting requested review from seanmalloy

Assignees

@damemi damemi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a7i @k8s-ci-robot @damemi