Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to Go 1.23.3 #1565

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Bump to Go 1.23.3 #1565

merged 1 commit into from
Dec 4, 2024

Conversation

seanmalloy
Copy link
Member

The k/k repo was bumped to Go 1.23.3. See below PR for reference.

kubernetes/kubernetes#128852

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 3, 2024
@seanmalloy
Copy link
Member Author

I need to update the CI configuration with the new Go version before merging this.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 3, 2024
seanmalloy added a commit to seanmalloy/test-infra that referenced this pull request Dec 3, 2024
@seanmalloy
Descheduler Bump Go Version to 1.23.3
c3f3f37 
Required for kubernetes-sigs/descheduler#1565
@seanmalloy seanmalloy mentioned this pull request Dec 3, 2024
Merged
@a7i
Copy link
Contributor

a7i commented Dec 3, 2024

/retest

@a7i
Copy link
Contributor

a7i commented Dec 3, 2024

does this need to be updated as well?
https://github.com/kubernetes-sigs/descheduler/blob/master/hack/lib/go.sh#L22

@seanmalloy
Copy link
Member Author

/retest

@a7i
Copy link
Contributor

a7i commented Dec 3, 2024

@seanmalloy the error is:

Unknown go version 'go1.23.3', skipping gofmt.
make: *** [Makefile:118: verify-gofmt] Error 1

this file needs to be updated to include 1.23: https://github.com/kubernetes-sigs/descheduler/blob/master/hack/lib/go.sh#L22

@seanmalloy
Bump to Go 1.23.3
00b6e35 
The k/k repo was bumped to Go 1.23.3. See below PR for reference.

kubernetes/kubernetes#128852
@seanmalloy
Copy link
Member Author

/retest

@seanmalloy
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 4, 2024
@seanmalloy
Copy link
Member Author

/test pull-descheduler-test-e2e-k8s-master-1-28

@k8s-ci-robot
Copy link
Contributor

@seanmalloy: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-descheduler-test-e2e-k8s-master-1-29
  • /test pull-descheduler-test-e2e-k8s-master-1-30
  • /test pull-descheduler-test-e2e-k8s-master-1-31
  • /test pull-descheduler-unit-test-master-master
  • /test pull-descheduler-verify-build-master
  • /test pull-descheduler-verify-master

Use /test all to run the following jobs that were automatically triggered:

  • pull-descheduler-test-e2e-k8s-master-1-29
  • pull-descheduler-test-e2e-k8s-master-1-30
  • pull-descheduler-test-e2e-k8s-master-1-31
  • pull-descheduler-verify-build-master
  • pull-descheduler-verify-master

In response to this:

/test pull-descheduler-test-e2e-k8s-master-1-28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@seanmalloy
Copy link
Member Author

/assign @a7i @ingvagabund @damemi

@a7i
Copy link
Contributor

a7i commented Dec 4, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a7i

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2024
@k8s-ci-robot k8s-ci-robot merged commit a8e14ec into kubernetes-sigs:master Dec 4, 2024
8 checks passed
@seanmalloy seanmalloy deleted the go-bump-1.23.3 branch December 4, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaneLiuL JaneLiuL Awaiting requested review from JaneLiuL

@knelasevero knelasevero Awaiting requested review from knelasevero

Assignees

@damemi damemi

@ingvagabund ingvagabund

@a7i a7i

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@seanmalloy @a7i @k8s-ci-robot @damemi @ingvagabund