Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golangci-lint to 1.62.2 #1567

Merged

Conversation

seanmalloy
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 4, 2024
@seanmalloy
Copy link
Member Author

I've now seen this timeout error happen on 2 PRs in the last 24 hours.

curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b ./_output/bin v1.62.2
golangci/golangci-lint info checking GitHub for tag 'v1.62.2'
golangci/golangci-lint info found version: 1.62.2 for v1.62.2/linux/amd64
golangci/golangci-lint info installed ./_output/bin/golangci-lint
./_output/bin/golangci-lint run
{"component":"entrypoint","file":"sigs.k8s.io/prow/pkg/entrypoint/run.go:169","func":"sigs.k8s.io/prow/pkg/entrypoint.Options.ExecuteProcess","level":"error","msg":"Process did not finish before 10m0s timeout","severity":"error","time":"2024-12-04T22:14:29Z"}
level=error msg="Timeout exceeded: try increasing it by passing --timeout option"
make: *** [Makefile:150: lint] Error 4
{"component":"entrypoint","file":"sigs.k8s.io/prow/pkg/entrypoint/run.go:264","func":"sigs.k8s.io/prow/pkg/entrypoint.gracefullyTerminate","level":"error","msg":"Process gracefully exited before 15m0s grace period","severity":"error","time":"2024-12-04T22:17:15Z"}

I'm going to investigate bumping the CI timeout to something more than 10 minutes for this job.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 4, 2024
@seanmalloy
Copy link
Member Author

I've created kubernetes/test-infra#33907 to standardize all the CI job timeouts and bump the verify jobs from 10m to 15m.

@jklaw90
Copy link
Contributor

jklaw90 commented Dec 5, 2024

would that fix update the golangci-lint timeout config?

@seanmalloy
Copy link
Member Author

would that fix update the golangci-lint timeout config?

Yes, it will bump the timeout from 10 minutes to 15 minutes. If the CI job still fails periodclically after this change then we can try bumping it higher.

@seanmalloy
Copy link
Member Author

/retest

@seanmalloy
Copy link
Member Author

/hold cancel
/assign @a7i @damemi

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2024
@a7i
Copy link
Contributor

a7i commented Dec 5, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a7i

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit e619ec6 into kubernetes-sigs:master Dec 5, 2024
8 checks passed
@seanmalloy seanmalloy deleted the golangci-lint-bump-1.62.2 branch December 5, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants