Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump to kubernetes v0.32.0-rc.2 #1569

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

a7i
Copy link
Contributor

@a7i a7i commented Dec 6, 2024

in preparation for v0.32 release

Summary
The 1.32 release cycle is as follows:

Monday 9th September 2024: Week 1 — Release cycle begins
Thursday 3rd October 2024: Week 4 — Production Readiness Freeze
02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024: Week 5 — Enhancements Freeze
02:00 UTC Friday 8th November 2024 / 19:00 PDT Thursday 7th November 2024: Week 9 — Code Freeze and Test Freeze
Tuesday 12th - Friday 15th November 2024: Week 10 - KubeCon NA
Tuesday 26th November 2024: Week 12 — Docs Freeze
Tuesday 11th December 2024: Week 14 — Kubernetes v1.32.0 released

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 6, 2024
@a7i a7i force-pushed the bump-v0.32.0-rc.2 branch 2 times, most recently from 2fcf7c5 to d7d2003 Compare December 6, 2024 16:11
@seanmalloy
Copy link
Member

golanglint-ci timed out in CI ...

curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b ./_output/bin v1.62.2
golangci/golangci-lint info checking GitHub for tag 'v1.62.2'
golangci/golangci-lint info found version: 1.62.2 for v1.62.2/linux/amd64
golangci/golangci-lint info installed ./_output/bin/golangci-lint
./_output/bin/golangci-lint run
level=error msg="Timeout exceeded: try increasing it by passing --timeout option"
make: *** [Makefile:150: lint] Error 4

/retest

@seanmalloy
Copy link
Member

Per the docs the default timeout for golangci-lint is one minute, https://golangci-lint.run/usage/configuration/. We should bump this up.

@seanmalloy
Copy link
Member

@a7i we now have a real error in CI. See below.

./hack/verify-docs.sh
Generated output differs:
diff -Naupr /home/prow/go/src/sigs.k8s.io/descheduler/hack/../docs/cli/descheduler.md /tmp/tmp.zNyUKu25Ap/descheduler.md
--- /home/prow/go/src/sigs.k8s.io/descheduler/hack/../docs/cli/descheduler.md	2024-12-06 18:33:00.624234637 +0000
+++ /tmp/tmp.zNyUKu25Ap/descheduler.md	2024-12-06 18:37:59.350387463 +0000
@@ -33,7 +33,7 @@ descheduler [flags]
       --leader-elect                             Start a leader election client and gain leadership before executing the main loop. Enable this when running replicated components for high availability.
       --leader-elect-lease-duration duration     The duration that non-leader candidates will wait after observing a leadership renewal until attempting to acquire leadership of a led but unrenewed leader slot. This is effectively the maximum duration that a leader can be stopped before it is replaced by another candidate. This is only applicable if leader election is enabled. (default 2m17s)
       --leader-elect-renew-deadline duration     The interval between attempts by the acting master to renew a leadership slot before it stops leading. This must be less than the lease duration. This is only applicable if leader election is enabled. (default 1m47s)
-      --leader-elect-resource-lock string        The type of resource object that is used for locking during leader election. Supported options are 'leases', 'endpointsleases' and 'configmapsleases'. (default "leases")
+      --leader-elect-resource-lock string        The type of resource object that is used for locking during leader election. Supported options are 'leases'. (default "leases")
       --leader-elect-resource-name string        The name of resource object that is used for locking during leader election. (default "descheduler")
       --leader-elect-resource-namespace string   The namespace of resource object that is used for locking during leader election. (default "kube-system")
       --leader-elect-retry-period duration       The duration the clients should wait between attempting acquisition and renewal of a leadership. This is only applicable if leader election is enabled. (default 26s)
Generated conversions verify failed. Please run ./hack/update-docs.sh
make: *** [Makefile:145: verify-gen] Error 1

I'll submit a separate PR to bump the golangci-lint timeout to something more than 1 minute.

@a7i
Copy link
Contributor Author

a7i commented Dec 6, 2024

@a7i we now have a real error in CI. See below.

./hack/verify-docs.sh
Generated output differs:
diff -Naupr /home/prow/go/src/sigs.k8s.io/descheduler/hack/../docs/cli/descheduler.md /tmp/tmp.zNyUKu25Ap/descheduler.md
--- /home/prow/go/src/sigs.k8s.io/descheduler/hack/../docs/cli/descheduler.md	2024-12-06 18:33:00.624234637 +0000
+++ /tmp/tmp.zNyUKu25Ap/descheduler.md	2024-12-06 18:37:59.350387463 +0000
@@ -33,7 +33,7 @@ descheduler [flags]
       --leader-elect                             Start a leader election client and gain leadership before executing the main loop. Enable this when running replicated components for high availability.
       --leader-elect-lease-duration duration     The duration that non-leader candidates will wait after observing a leadership renewal until attempting to acquire leadership of a led but unrenewed leader slot. This is effectively the maximum duration that a leader can be stopped before it is replaced by another candidate. This is only applicable if leader election is enabled. (default 2m17s)
       --leader-elect-renew-deadline duration     The interval between attempts by the acting master to renew a leadership slot before it stops leading. This must be less than the lease duration. This is only applicable if leader election is enabled. (default 1m47s)
-      --leader-elect-resource-lock string        The type of resource object that is used for locking during leader election. Supported options are 'leases', 'endpointsleases' and 'configmapsleases'. (default "leases")
+      --leader-elect-resource-lock string        The type of resource object that is used for locking during leader election. Supported options are 'leases'. (default "leases")
       --leader-elect-resource-name string        The name of resource object that is used for locking during leader election. (default "descheduler")
       --leader-elect-resource-namespace string   The namespace of resource object that is used for locking during leader election. (default "kube-system")
       --leader-elect-retry-period duration       The duration the clients should wait between attempting acquisition and renewal of a leadership. This is only applicable if leader election is enabled. (default 26s)
Generated conversions verify failed. Please run ./hack/update-docs.sh
make: *** [Makefile:145: verify-gen] Error 1

I'll submit a separate PR to bump the golangci-lint timeout to something more than 1 minute.

ah I think you!

@a7i a7i force-pushed the bump-v0.32.0-rc.2 branch from d7d2003 to 9e0d036 Compare December 6, 2024 19:13
@seanmalloy
Copy link
Member

CI job pull-descheduler-verify-master has been running for a long time now, and seems to be stuck on golangci-lint. I'll submit a separate PR to add the -v flag for golangci-lint, so that we can hopefully debug the various timeout issues better in the future.

image

@a7i
Copy link
Contributor Author

a7i commented Dec 6, 2024

alright, let me do a force push to re-trigger it

@a7i a7i force-pushed the bump-v0.32.0-rc.2 branch from 9e0d036 to f4c3fdf Compare December 6, 2024 21:25
@seanmalloy
Copy link
Member

/test pull-descheduler-test-e2e-k8s-master-1-29

@seanmalloy
Copy link
Member

/test pull-descheduler-verify-master

@seanmalloy
Copy link
Member

/approve
/assign @jklaw90

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seanmalloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2024
@jklaw90
Copy link
Contributor

jklaw90 commented Dec 11, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2024
@k8s-ci-robot k8s-ci-robot merged commit 51a004c into kubernetes-sigs:master Dec 11, 2024
8 of 9 checks passed
@a7i a7i deleted the bump-v0.32.0-rc.2 branch December 11, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants