Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable golangci-lint Verbose Output #1572

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Enable golangci-lint Verbose Output #1572

merged 1 commit into from
Dec 11, 2024

Conversation

seanmalloy
Copy link
Member

The golangci-lint tool gets stuck for a variety of reasons when running in Prow CI. Enabling verbose output in an attempt to make debugging easier.

ref: https://golangci-lint.run/contributing/debug/

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 6, 2024
@k8s-ci-robot k8s-ci-robot requested review from a7i and damemi December 6, 2024 21:32
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 6, 2024
@seanmalloy
Copy link
Member Author

This is a follow up to #1571 and kubernetes/test-infra#33907 to try an debug the various timeout issues.

/cc @jklaw90
/assign @a7i

@k8s-ci-robot k8s-ci-robot requested a review from jklaw90 December 6, 2024 21:35
@seanmalloy
Copy link
Member Author

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Dec 6, 2024
@a7i
Copy link
Contributor

a7i commented Dec 6, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a7i

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2024
@jklaw90
Copy link
Contributor

jklaw90 commented Dec 6, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2024
@seanmalloy
Copy link
Member Author

Hit the 40 minute prow timeout. Let's try again.

/retest

@seanmalloy
Copy link
Member Author

/retest

@seanmalloy
Enable golangci-lint Verbose Output
73fecfb 
The golangci-lint tool gets stuck for a variety of reasons when
running in Prow CI. Enabling verbose output in an attempt to make
debugging easier.

ref: https://golangci-lint.run/contributing/debug/
@seanmalloy seanmalloy force-pushed the golangci-lint-verbose branch from 2d48936 to 73fecfb Compare December 7, 2024 04:44
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2024
@seanmalloy
Copy link
Member Author

seanmalloy commented Dec 7, 2024 •
edited
Loading

/test pull-descheduler-verify-master

1 similar comment
@seanmalloy
Copy link
Member Author

/test pull-descheduler-verify-master

@a7i
Copy link
Contributor

a7i commented Dec 7, 2024

/retest

@seanmalloy
Copy link
Member Author

/retest pull-descheduler-verify-master

@k8s-ci-robot
Copy link
Contributor

@seanmalloy: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test pull-descheduler-test-e2e-k8s-master-1-29
  • /test pull-descheduler-test-e2e-k8s-master-1-30
  • /test pull-descheduler-test-e2e-k8s-master-1-31
  • /test pull-descheduler-unit-test-master-master
  • /test pull-descheduler-verify-build-master
  • /test pull-descheduler-verify-master

Use /test all to run the following jobs that were automatically triggered:

  • pull-descheduler-test-e2e-k8s-master-1-29
  • pull-descheduler-test-e2e-k8s-master-1-30
  • pull-descheduler-test-e2e-k8s-master-1-31
  • pull-descheduler-verify-build-master
  • pull-descheduler-verify-master

In response to this:

/retest pull-descheduler-verify-master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@seanmalloy
Copy link
Member Author

/test pull-descheduler-verify-master

1 similar comment
@seanmalloy
Copy link
Member Author

/test pull-descheduler-verify-master

@seanmalloy
Copy link
Member Author

@jklaw90 can you review again?

@jklaw90
Copy link
Contributor

jklaw90 commented Dec 11, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2024
@k8s-ci-robot k8s-ci-robot merged commit 44bde42 into kubernetes-sigs:master Dec 11, 2024
8 checks passed
@seanmalloy seanmalloy deleted the golangci-lint-verbose branch December 11, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a7i a7i Awaiting requested review from a7i

@damemi damemi Awaiting requested review from damemi

@jklaw90 jklaw90 Awaiting requested review from jklaw90

Assignees

@jklaw90 jklaw90

@a7i a7i

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seanmalloy @a7i @k8s-ci-robot @jklaw90