-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix golangci-lint timeout issue in CI #1574
Conversation
2 of 2 successful runs.
|
33c72ff
to
8389e9a
Compare
/test pull-descheduler-verify-master |
1 similar comment
/test pull-descheduler-verify-master |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a7i The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@seanmalloy fyi, here is the resource utilization: it looks to be a resource issue but it's already pretty high: https://github.com/a7i/test-infra/blob/master/config/jobs/kubernetes-sigs/descheduler/descheduler-presubmits-master.yaml#L53-L57 |
/test pull-descheduler-verify-master |
Updates since merging kubernetes/test-infra#33946. It looks like we might be good now after bumping CPU to 8 and Memory to 8 GBi 10 of 10 runs successful.
I'll run the |
/test pull-descheduler-verify-master |
Looks like I did not need to increase memory, but it used up whatever CPU we gave it |
/test pull-descheduler-verify-master |
@seanmalloy: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/test pull-descheduler-verify-master |
7 similar comments
/test pull-descheduler-verify-master |
/test pull-descheduler-verify-master |
/test pull-descheduler-verify-master |
/test pull-descheduler-verify-master |
/test pull-descheduler-verify-master |
/test pull-descheduler-verify-master |
/test pull-descheduler-verify-master |
Bumping CPU and Memory seems to have fixed the issue with the pull-descheduler-verify-master CI job randomly failing. See #1574 (comment) for a detailed summary. References:
/close |
@seanmalloy: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Trying to pinpoint what is causing the golangci-lint timouts when running in CI.
/hold