Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix golangci-lint timeout issue in CI #1574

Closed

Conversation

seanmalloy
Copy link
Member

Trying to pinpoint what is causing the golangci-lint timouts when running in CI.

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 11, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 11, 2024
@seanmalloy
Copy link
Member Author

seanmalloy commented Dec 12, 2024

2 of 2 successful runs.

  • Run 1: (no link)
level=info msg="Memory: 1774 samples, avg is 3396.9MB, max is 4070.3MB"
level=info msg="Execution took 3m16.835370238s"
level=info msg="Memory: 609 samples, avg is 1882.0MB, max is 3888.8MB"
level=info msg="Execution took 1m17.730608964s"
level=info msg="Memory: 607 samples, avg is 1898.0MB, max is 3980.1MB"
level=info msg="Execution took 1m18.31162079s"

@seanmalloy
Copy link
Member Author

/test pull-descheduler-verify-master

1 similar comment
@seanmalloy
Copy link
Member Author

/test pull-descheduler-verify-master

@a7i
Copy link
Contributor

a7i commented Dec 13, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a7i

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2024
@seanmalloy
Copy link
Member Author

/test pull-descheduler-verify-master

@seanmalloy
Copy link
Member Author

seanmalloy commented Dec 13, 2024

Updates since merging kubernetes/test-infra#33946. It looks like we might be good now after bumping CPU to 8 and Memory to 8 GBi

10 of 10 runs successful.

  • Run 1
level=info msg="Memory: 467 samples, avg is 2106.0MB, max is 4766.7MB"
level=info msg="Execution took 59.135479519s"
  • Run 2
level=info msg="Memory: 502 samples, avg is 2110.4MB, max is 4781.9MB"
level=info msg="Execution took 1m0.066928051s"
  • Run 3
level=info msg="Memory: 453 samples, avg is 1969.9MB, max is 4467.3MB"
level=info msg="Execution took 58.908604213s"
  • Run 4
level=info msg="Memory: 464 samples, avg is 2096.0MB, max is 4552.1MB"
level=info msg="Execution took 58.62517406s"
  • Run 5
level=info msg="Memory: 502 samples, avg is 1941.8MB, max is 3946.4MB"
level=info msg="Execution took 1m1.485046295s"
  • Run 6
level=info msg="Memory: 471 samples, avg is 1983.0MB, max is 4115.5MB"
level=info msg="Execution took 1m0.903941678s"
  • Run 7
level=info msg="Memory: 507 samples, avg is 1946.7MB, max is 4016.3MB"
level=info msg="Execution took 59.137035231s"
  • Run 8
evel=info msg="Memory: 502 samples, avg is 2084.3MB, max is 4759.1MB"
level=info msg="Execution took 1m1.973715188s"
  • Run 9
level=info msg="Memory: 515 samples, avg is 1959.0MB, max is 4236.8MB"
level=info msg="Execution took 1m2.449222029s"
  • Run 10
level=info msg="Memory: 518 samples, avg is 1952.9MB, max is 3913.6MB"
level=info msg="Execution took 1m3.571413578s"

I'll run the pull-descheduler-verify-master CI job against this PR a few more times to make sure we are all good and then close this PR.

@seanmalloy
Copy link
Member Author

/test pull-descheduler-verify-master

@a7i
Copy link
Contributor

a7i commented Dec 13, 2024

@seanmalloy
Copy link
Member Author

/test pull-descheduler-verify-master

@k8s-ci-robot
Copy link
Contributor

@seanmalloy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-descheduler-test-e2e-k8s-master-1-31 bd023b8 link true /test pull-descheduler-test-e2e-k8s-master-1-31

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@seanmalloy
Copy link
Member Author

/test pull-descheduler-verify-master

7 similar comments
@seanmalloy
Copy link
Member Author

/test pull-descheduler-verify-master

@seanmalloy
Copy link
Member Author

/test pull-descheduler-verify-master

@seanmalloy
Copy link
Member Author

/test pull-descheduler-verify-master

@seanmalloy
Copy link
Member Author

/test pull-descheduler-verify-master

@seanmalloy
Copy link
Member Author

/test pull-descheduler-verify-master

@seanmalloy
Copy link
Member Author

/test pull-descheduler-verify-master

@seanmalloy
Copy link
Member Author

/test pull-descheduler-verify-master

@seanmalloy
Copy link
Member Author

seanmalloy commented Dec 14, 2024

Bumping CPU and Memory seems to have fixed the issue with the pull-descheduler-verify-master CI job randomly failing. See #1574 (comment) for a detailed summary.

References:

/close

@k8s-ci-robot
Copy link
Contributor

@seanmalloy: Closed this PR.

In response to this:

Bump CPU and Memory seems to have fixed the issue with the pull-descheduler-verify-master CI job randomly failing. See #1574 (comment) for a detailed summary.

References:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@seanmalloy seanmalloy deleted the fix-golangci-lint branch December 14, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants