-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add model server protocol proposal #164
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: liu-cong The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -0,0 +1,72 @@ | |||
# Model Server Protocol for Gateway API Inference Extension |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smarterclayton @robscott I think we need to explicitly define two "contracts":
Contract 1 is the one between the gateway and the endpoint picker extension; this contract is defined by the InferenceModel/InferencePool APIs.
Contract 2 is the one between the reference implementation of the endpoint picker and the model server.
For each contract, we need separately establish versioning and define conformance tests and my view is that we should not make them dependent on each other.
The InferencePool API could have a way to communicate to the endpoint picker which protocol to use (e.g., as part of the extension config API), but for the most part it should be part of some raw parameters config (e.g., a map or a generic reference to a CRD) that the extension understands and knowns how to interpret.
This is adapted from the initial doc
I didn't include the ORCA load reporting section as it's not currently required by the inference extension, though parallel efforts are happening. The intention is to keep the scope of this protocol small and expand in the future if needed.
Much of the protocol items are "SHOULD" instead of "MUST" given the following reasons:
I see this as a very initial effort to define the contract, and is an evolving process to monitor industry trends and drive more unification.