Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.6] issue-639: Add labels from command line option to filestore backup resource #888

Open
wants to merge 1 commit into
base: release-1.6
Choose a base branch
from
Open

[release-1.6] issue-639: Add labels from command line option to filestore backup resource #888

wants to merge 1 commit into from

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #640

/assign mattcary

NONE

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jun 14, 2024
Merged
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 14, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: k8s-infra-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign mattcary for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 14, 2024
@bharath-b-rh
Copy link
Contributor

/cc @pwschuurman @leiyiz

@bharath-b-rh
Copy link
Contributor

/assign @bharath-b-rh

@bharath-b-rh
Copy link
Contributor

@pwschuurman / @leiyiz Could you please help me with the PR review. This is a cherry-pick of the changes merged in master.

@bharath-b-rh
Copy link
Contributor

@leiyiz Could you please help me with the PR review.

@mattcary
Copy link
Contributor

mattcary commented Aug 2, 2024

@bharath-b-rh

How critical is it to backport this? If we backport it here, it will also be backported in GKE, and we're not sure we can justify that.

@bharath-b-rh
Copy link
Contributor

@bharath-b-rh

How critical is it to backport this? If we backport it here, it will also be backported in GKE, and we're not sure we can justify that.

@mattcary This will help in keeping the resource labeling feature consistent and helps in managing the resources.

@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 16, 2024
@bharath-b-rh bharath-b-rh mentioned this pull request Aug 27, 2024
Open
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 14, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannawang0221 dannawang0221 Awaiting requested review from dannawang0221

@mattcary mattcary Awaiting requested review from mattcary

@leiyiz leiyiz Awaiting requested review from leiyiz

@pwschuurman pwschuurman Awaiting requested review from pwschuurman

Assignees

@mattcary mattcary

@bharath-b-rh bharath-b-rh

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@k8s-infra-cherrypick-robot @k8s-ci-robot @bharath-b-rh @mattcary @k8s-triage-robot