-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable config map update retry mechanism during NodeStageVolume #983
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: siyanshen The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @siyanshen. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
return nil | ||
} | ||
|
||
updateErr := s.lockReleaseController.UpdateConfigMapWithKeyValue(ctx, cm, lockInfoKey, filestoreIP) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the only place (UPDATE configmap) we need to have a retry mechanism, rather than the entire node stage volume function.
@siyanshen: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR implements a retry mechanism in NodeStageVolume- Instead of failing the NodeStageVolume operation after a single attempt to update the ConfigMap, a retry logic should be introduced. This would ensure that the operation continues to attempt updates until it succeeds, reducing the chance of unnecessary failures.
Why we need this? Before this change, there is a case where the CSI driver attempts to mount multiple Filestore-based volumes. During this process, the CSI driver stores lock info in a ConfigMap, which tracks the mounted Filestore information for each node. However, this can lead to conflicts when multiple NodeStageVolume calls attempt to update the ConfigMap simultaneously. In such cases, the update may fail because the key-value pairs have already been modified by another process. The resulting error message may look like this:
This is not an unrecoverable error, as the operation will self-resolve during a subsequent NodeStageVolume call and eventually succeed within milliseconds.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: