Istio provider: register provider.

kubernetes-sigs · Dec 30, 2023 · 2293259 · 2293259
1 parent e8cf702
commit 2293259
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/cmd/print.go b/cmd/print.go
@@ -29,6 +29,7 @@ import (
 
 	// Call init function for the providers
 	_ "github.com/kubernetes-sigs/ingress2gateway/pkg/i2gw/providers/ingressnginx"
+	_ "github.com/kubernetes-sigs/ingress2gateway/pkg/i2gw/providers/istio"
 	_ "github.com/kubernetes-sigs/ingress2gateway/pkg/i2gw/providers/kong"
 )
 

diff --git a/pkg/i2gw/providers/istio/istio.go b/pkg/i2gw/providers/istio/istio.go
@@ -48,10 +48,8 @@ func NewProvider(conf *i2gw.ProviderConf) i2gw.Provider {
 
 // ToGatewayAPI converts stored Istio API entities to i2gw.GatewayResources
 // K8S Ingress resources are not needed, only Istio-based are converted
-// TODO(#100) - add istio conversion logic
 func (p *Provider) ToGatewayAPI(_ i2gw.InputResources) (i2gw.GatewayResources, field.ErrorList) {
-	p.converter.convert(p.storage)
-	return i2gw.GatewayResources{}, field.ErrorList{field.Forbidden(field.NewPath(""), "conversion is WIP")}
+	return p.converter.convert(p.storage)
 }
 
 func (p *Provider) ReadResourcesFromCluster(ctx context.Context) error {