-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor addBackendPolicyIfConfigured to allow future features #192
Conversation
f7219b3
to
0cea547
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sawsa307!
Type: &affinityType, | ||
} | ||
if affinityType == "GENERATED_COOKIE" { | ||
saConfig.CookieTTLSec = serviceIR.Gce.SessionAffinity.CookieTTLSec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: how do we usually handle invalid config? Could we add a log here if the backendConfig had affinityCookieTtlSec
set without affinityType
of GENERATED_COOKIE
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good! Created a function to check backend config before processing translation.
official /lgtm /approve (although I don't have OWNERS approval) |
/assign @spencerhance |
f81472a
to
2dbec7c
Compare
Thanks @sawsa307! Will defer to @LiorLieberman for final approval. /lgtm |
/lgtm Thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LiorLieberman, sawsa307, spencerhance The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Refactor IR in GCE to allow additional features.
Which issue(s) this PR fixes:
Does this PR introduce a user-facing change?: