Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor addBackendPolicyIfConfigured to allow future features #192

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

sawsa307
Copy link
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Refactor IR in GCE to allow additional features.

Which issue(s) this PR fixes:

Does this PR introduce a user-facing change?:

None

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 12, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 12, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 12, 2024
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 12, 2024
Copy link

@spencerhance spencerhance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sawsa307!

Type: &affinityType,
}
if affinityType == "GENERATED_COOKIE" {
saConfig.CookieTTLSec = serviceIR.Gce.SessionAffinity.CookieTTLSec

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: how do we usually handle invalid config? Could we add a log here if the backendConfig had affinityCookieTtlSec set without affinityType of GENERATED_COOKIE?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! Created a function to check backend config before processing translation.

@spencerhance
Copy link

official /lgtm /approve

(although I don't have OWNERS approval)

@sawsa307
Copy link
Contributor Author

/assign @spencerhance
/assign @LiorLieberman

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 12, 2024
@robscott
Copy link
Member

Thanks @sawsa307! Will defer to @LiorLieberman for final approval.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 12, 2024
@LiorLieberman
Copy link
Member

/lgtm
/approve

Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LiorLieberman, sawsa307, spencerhance

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit 21aef86 into kubernetes-sigs:main Sep 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants