Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FrontendConfig to storage when read from file #196

Closed
wants to merge 1 commit into from
Closed

Add FrontendConfig to storage when read from file #196

wants to merge 1 commit into from

Conversation

sawsa307
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:
Add frontend config to storage when reading from file.

Which issue(s) this PR fixes:
Fix an issue in #194 when reading frontend config from file.

Does this PR introduce a user-facing change?:

None

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 30, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sawsa307
Once this PR has been reviewed and has the lgtm label, please assign liorlieberman for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 30, 2024
@sawsa307 sawsa307 force-pushed the add-feconfig-from-file branch from 1ebc3ad to f717ac7 Compare September 30, 2024 20:58
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 30, 2024
@sawsa307 sawsa307 force-pushed the add-feconfig-from-file branch 2 times, most recently from 10894ca to b349b34 Compare September 30, 2024 20:59
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 30, 2024
@sawsa307 sawsa307 force-pushed the add-feconfig-from-file branch from b349b34 to 8484773 Compare September 30, 2024 21:00
@sawsa307 sawsa307 closed this Sep 30, 2024
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 30, 2024
@sawsa307 sawsa307 deleted the add-feconfig-from-file branch September 30, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levikobi levikobi Awaiting requested review from levikobi

@Xunzhuo Xunzhuo Awaiting requested review from Xunzhuo

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sawsa307 @k8s-ci-robot