Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: kong implementationSpecific pathType #89

Merged
merged 5 commits into from
Nov 16, 2023
Merged

feat: kong implementationSpecific pathType #89

merged 5 commits into from
Nov 16, 2023

Conversation

mlavacca
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #88

Does this PR introduce a user-facing change?:

Kong supports `ImplementationSpecific` as `PathType` and converts it into `RegularExpression.`

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 26, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 26, 2023
@mlavacca mlavacca temporarily deployed to release October 26, 2023 13:52 — with GitHub Actions Inactive
@mlavacca mlavacca force-pushed the kong-implementation-specific-path branch from 5b7c2dd to bffefcd Compare October 27, 2023 08:43
@k8s-ci-robot k8s-ci-robot removed the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 27, 2023
@mlavacca mlavacca temporarily deployed to release October 27, 2023 08:43 — with GitHub Actions Inactive
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 27, 2023
@mlavacca mlavacca temporarily deployed to release October 27, 2023 12:19 — with GitHub Actions Inactive
@mlavacca mlavacca force-pushed the kong-implementation-specific-path branch from 0c771c3 to 851ae55 Compare November 11, 2023 08:04
@mlavacca mlavacca force-pushed the kong-implementation-specific-path branch from 851ae55 to 6fa9c25 Compare November 11, 2023 08:25
@mlavacca
implementation-specific options
ed3aee3 
A new options struct has been introduced. Such a struct can be
customized by providers to implement provider-specific API features.

Signed-off-by: Mattia Lavacca <[email protected]>
@mlavacca mlavacca force-pushed the kong-implementation-specific-path branch from 6fa9c25 to ed3aee3 Compare November 11, 2023 08:36
LiorLieberman
LiorLieberman reviewed Nov 13, 2023
View reviewed changes
Copy link
Member

@LiorLieberman LiorLieberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mattia! thats awesome!

I like this approach. Left a few comments.

pkg/i2gw/providers/kong/converter_test.go Outdated Show resolved Hide resolved
pkg/i2gw/providers/kong/README.md Outdated Show resolved Hide resolved
pkg/i2gw/providers/ingressnginx/converter_test.go Outdated Show resolved Hide resolved
pkg/i2gw/providers/common/converter.go Outdated Show resolved Hide resolved
pkg/i2gw/providers/common/converter.go Outdated Show resolved Hide resolved
pkg/i2gw/provider.go Outdated Show resolved Hide resolved
@mlavacca mlavacca force-pushed the kong-implementation-specific-path branch from 648d0b5 to 05792aa Compare November 13, 2023 10:53
@mlavacca mlavacca force-pushed the kong-implementation-specific-path branch from 05792aa to 4bb3faf Compare November 13, 2023 11:12
@mlavacca mlavacca force-pushed the kong-implementation-specific-path branch from 4bb3faf to d2f601d Compare November 13, 2023 11:16
levikobi
levikobi reviewed Nov 13, 2023
View reviewed changes
Copy link
Member

@levikobi levikobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change @mlavacca! I think it will make things easier as we advance.

pkg/i2gw/provider.go Outdated Show resolved Hide resolved
@mlavacca
feat: reviews comments addressed
08daf0c 
Signed-off-by: Mattia Lavacca <[email protected]>
@mlavacca mlavacca force-pushed the kong-implementation-specific-path branch from d2f601d to 08daf0c Compare November 13, 2023 14:56
@mlavacca mlavacca force-pushed the kong-implementation-specific-path branch from 35056f5 to e5e8f48 Compare November 14, 2023 07:36
@mlavacca
options moved to converter.
d586b06 
Signed-off-by: Mattia Lavacca <[email protected]>
@mlavacca mlavacca force-pushed the kong-implementation-specific-path branch from e5e8f48 to d586b06 Compare November 14, 2023 07:39
LiorLieberman
LiorLieberman reviewed Nov 14, 2023
View reviewed changes
Copy link
Member

@LiorLieberman LiorLieberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mattia, thats awesome!
mostly lgtm, just a few last nits

pkg/i2gw/provider.go Outdated Show resolved Hide resolved
pkg/i2gw/provider.go Outdated Show resolved Hide resolved
pkg/i2gw/providers/common/converter.go Outdated Show resolved Hide resolved
pkg/i2gw/providers/kong/converter.go Outdated Show resolved Hide resolved
pkg/i2gw/providers/kong/implementation_specific.go Outdated Show resolved Hide resolved
levikobi
levikobi reviewed Nov 15, 2023
View reviewed changes
pkg/i2gw/providers/common/converter.go Outdated Show resolved Hide resolved
pkg/i2gw/providers/kong/converter.go Outdated Show resolved Hide resolved
@mlavacca mlavacca force-pushed the kong-implementation-specific-path branch from 369a6a3 to fb48966 Compare November 15, 2023 10:38
LiorLieberman
LiorLieberman approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@LiorLieberman LiorLieberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, approving with two small nits.

Will leave @levikobi for lgtm

PROVIDER.md Outdated Show resolved Hide resolved
pkg/i2gw/providers/kong/converter_test.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2023
@mlavacca
reviews' comments addressed
94e1d82 
Signed-off-by: Mattia Lavacca <[email protected]>
@mlavacca mlavacca force-pushed the kong-implementation-specific-path branch from fb48966 to 94e1d82 Compare November 15, 2023 13:32
levikobi
levikobi approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@levikobi levikobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution as always. Thanks @mlavacca!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: levikobi, LiorLieberman, mlavacca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0ac84b9 into kubernetes-sigs:main Nov 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiorLieberman LiorLieberman LiorLieberman approved these changes

@levikobi levikobi levikobi approved these changes

@Xunzhuo Xunzhuo Awaiting requested review from Xunzhuo

Assignees

@levikobi levikobi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[kong] Convert ImplementationSpecific path type
4 participants
@mlavacca @k8s-ci-robot @levikobi @LiorLieberman