Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update make test - add verbosity & count #92

Closed
wants to merge 1 commit into from

Conversation

levikobi
Copy link
Member

@levikobi levikobi commented Oct 31, 2023

What type of PR is this?

/kind test

What this PR does / why we need it:

Run the tests more than once to detect flaky tests (such as #91).
Secondly, output verbose information.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

None

1. Make the output verbose
2. Run the tests more than once
@k8s-ci-robot
Copy link
Contributor

@levikobi: The label(s) kind/test cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind test

What this PR does / why we need it:

Run the tests more than once to detect flaky tests.
Secondly, output verbose information.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

None

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: levikobi
Once this PR has been reviewed and has the lgtm label, please assign bowei for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 31, 2023
@levikobi levikobi temporarily deployed to release October 31, 2023 19:10 — with GitHub Actions Inactive
@levikobi
Copy link
Member Author

/cc @LiorLieberman

@k8s-ci-robot
Copy link
Contributor

@levikobi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-ingress2gateway-test ab1c22c link true /test pull-ingress2gateway-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@LiorLieberman
Copy link
Member

/hold until we look at this together

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 1, 2023
@levikobi
Copy link
Member Author

@LiorLieberman I'm closing this one as we agreed not to run tests more than once in CI. Please reopen it if you change your mind.

@levikobi levikobi closed this Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants