Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kubectl kjob plugin. #4344

Merged

Conversation

mbobrovskyi
Copy link
Contributor

@mbobrovskyi mbobrovskyi commented Jan 14, 2025

Homepage: https://github.com/kubernetes-sigs/kjob/

Description: Tool for CLI-loving ML researchers.

@ahmetb
Copy link
Member

ahmetb commented Jan 14, 2025

🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖


Thanks for submitting your kubectl plugin to Krew!
One of the krew-index maintainers will review it soon. Note that the reviews for new plugin submissions may take a few days.

In the meanwhile, here are a few tips to make your plugin manifest better:

  • Make sure your plugin follows the best practices.
  • Eliminate redundant wording form shortDescription (it should be max 50 characters).
  • Try to word wrap your description to 80-character lines (no usage examples, please).

Thanks for your patience!
/kind new-plugin

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 14, 2025
@k8s-ci-robot k8s-ci-robot added kind/new-plugin size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 14, 2025
@mbobrovskyi
Copy link
Contributor Author

/cc @ahmetb @mimowo

@k8s-ci-robot k8s-ci-robot requested review from ahmetb and mimowo January 14, 2025 13:11
@mbobrovskyi mbobrovskyi changed the title Added kubectl kjob plugin. Add kubectl kjob plugin. Jan 14, 2025
@ahmetb
Copy link
Member

ahmetb commented Jan 14, 2025

Hi. The link is 404. Also are you one of the maintainers? Is the project committing to support publishing their plugin on Krew or are you just packaging it once without their knowledge?

plugins/kjob.yaml Outdated Show resolved Hide resolved
plugins/kjob.yaml Outdated Show resolved Hide resolved
@mbobrovskyi
Copy link
Contributor Author

Hi. The link is 404.

Ah, sorry. Fixed link https://github.com/kubernetes-sigs/kjob/. For now we don't have website. So I changed just for repo.

@mimowo
Copy link

mimowo commented Jan 15, 2025

Ah, sorry. Fixed link https://github.com/kubernetes-sigs/kjob/. For now we don't have website. So I changed just for repo.

Right, this is ticketed under kubernetes-sigs/kjob#8

@mbobrovskyi mbobrovskyi force-pushed the feature/kubectl-kjob-plugin branch from 49a2933 to 7146e66 Compare January 15, 2025 11:33
@mimowo
Copy link

mimowo commented Jan 15, 2025

LGTM

Copy link
Member

@ahmetb ahmetb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some cosmetic comments

plugins/kjob.yaml Outdated Show resolved Hide resolved
plugins/kjob.yaml Outdated Show resolved Hide resolved
plugins/kjob.yaml Outdated Show resolved Hide resolved
mbobrovskyi and others added 3 commits January 16, 2025 07:26
@mbobrovskyi mbobrovskyi force-pushed the feature/kubectl-kjob-plugin branch from b569cba to a77a5b4 Compare January 16, 2025 05:29
@ahmetb
Copy link
Member

ahmetb commented Jan 16, 2025

Can I confirm that Kueue project maintainers:

  1. Are aware that you're distributing this tool here
  2. Are committing to packaging and documenting kjob tool as a kubectl plugin?

Typically when the PR comes from personal repos matching submitter user we don't ask this. But I need to understand if you're one of the maintainers or maintainers are aware.

@mimowo
Copy link

mimowo commented Jan 16, 2025

@ahmetb I'm a maintainer of the Kueue and Kjob projects and I can confirm the above.

@ahmetb
Copy link
Member

ahmetb commented Jan 16, 2025

/lgtm
/approve
Thanks!
Also, please consider setting up Krew release automation which helps you skip manually making updates to your Krew manifests on each new version and send a pull request. It’s a GitHub workflow bot that can run every time you push a new tag. Those PRs are automatically approved.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, mbobrovskyi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2025
@k8s-ci-robot k8s-ci-robot merged commit 6ba6d73 into kubernetes-sigs:master Jan 16, 2025
3 checks passed
@mbobrovskyi mbobrovskyi deleted the feature/kubectl-kjob-plugin branch January 17, 2025 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/new-plugin lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants