-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kubectl kjob plugin. #4344
Add kubectl kjob plugin. #4344
Conversation
🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖 Thanks for submitting your kubectl plugin to Krew! In the meanwhile, here are a few tips to make your plugin manifest better:
Thanks for your patience! |
Hi. The link is 404. Also are you one of the maintainers? Is the project committing to support publishing their plugin on Krew or are you just packaging it once without their knowledge? |
Ah, sorry. Fixed link https://github.com/kubernetes-sigs/kjob/. For now we don't have website. So I changed just for repo. |
Right, this is ticketed under kubernetes-sigs/kjob#8 |
49a2933
to
7146e66
Compare
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some cosmetic comments
Co-authored-by: Ahmet Alp Balkan <[email protected]>
Co-authored-by: Ahmet Alp Balkan <[email protected]>
b569cba
to
a77a5b4
Compare
Can I confirm that Kueue project maintainers:
Typically when the PR comes from personal repos matching submitter user we don't ask this. But I need to understand if you're one of the maintainers or maintainers are aware. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, mbobrovskyi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Homepage: https://github.com/kubernetes-sigs/kjob/
Description: Tool for CLI-loving ML researchers.